Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1160945

Re: [PATCH][V3] usb: isp1760: check for null return from kzalloc

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Jun 08, 2015 at 02:22:06PM -0700, Greg Kroah-Hartman wrote:
> On Wed, Jun 03, 2015 at 03:43:23AM +0300, Laurent Pinchart wrote:
> > Hi Colin,
> > 
> > Thank you for the patch.
> > 
> > On Tuesday 02 June 2015 19:05:13 Colin King wrote:
> > > From: Colin Ian King <colin.king@canonical.com>
> > > 
> > > isp1760_ep_alloc_request allocates a structure with kzalloc without checking
> > > for NULL and then returns a pointer to one of the structure fields. As the
> > > field happens to be the first in the structure the caller can properly
> > > check for NULL, but this is risky if the structure layout is changed later.
> > > Add an explicit NULL check for the kzalloc return value
> > > 
> > > Detected with smatch static analysis:
> > > 
> > > drivers/usb/isp1760/isp1760-udc.c:816 isp1760_ep_alloc_request()
> > >   error: potential null dereference 'req'.  (kzalloc returns null)
> > > 
> > > [ thanks to Laurent Pinchart for improved commit message ]
> > > 
> > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > 
> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > 
> > Felipe, I expect you to pick this up, please let me know if there's any issue.
> 
> I'll just take it directly, thanks.

that works too, dropping from my queue.

-- 
balbi

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH][V3] usb: isp1760: check for null return from kzalloc Felipe Balbi <balbi@ti.com> - 2015-06-09 05:20 +0200

csiph-web