Re: [PATCH] oom: split out forced OOM killer

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	David Rientjes <rientjes@google.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] oom: split out forced OOM killer
Date	Mon, 08 Jun 2015 21:50:02 +0200
Message-ID	<pzbdw-dP-17@gated-at.bofh.it> (permalink)
References	<pwQdc-4ub-9@gated-at.bofh.it> <pxMhb-6Fj-9@gated-at.bofh.it> <pxXZ0-73F-11@gated-at.bofh.it> <pz9v4-646-23@gated-at.bofh.it> <pzar8-7tD-3@gated-at.bofh.it>
X-Original-To	Austin S Hemmelgarn <ahferroin7@gmail.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version:content-type; bh=5Yw4ctSl3yjLTUDyXOBIvWKEa1vdWc6sGzeQm3HL3yo=; b=lr1tLRFGfZV4AllPEAeGJSlzVAisQDnmu9p1x6uXuB5Oc6rPxZtqUq3AiHbNTF7B2a NClClbWyXDbfa3d1FJx/hxMypeYMTV+xDqorVLWu8xM3MHOdA8tsxS4VpAP+TV2auNpg 7IQ2cOTTiB00+PO/M/9UylrueuRWzFvOBg5FCGgMk6PF0TmFumzWuQ5hy/l5v2yw7nY3 lUCDimnVlc7FjAk2GkhCrmW1cHF+qJ1fqcx0/W9kNzYV2lQk5e2lBuxpJVkwg8z0b4yT 8jQBg9xNebzxF/4rzlf/fWCT9HjXWkNigz80rEtMydoPRcNfuROsrs0wr7bKN2/yZjIy ygaw==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version:content-type; bh=5Yw4ctSl3yjLTUDyXOBIvWKEa1vdWc6sGzeQm3HL3yo=; b=Jl8ggthx74LAWKP6Umdhg3+dRzOrGQvWftSkSCS2JUvzYxpC0nFFYfXIRvKYgYNh+w qWwLau0yAIkknFDDRx/FzUdGiGUAu3dwGwC5//NNuvxIEOyVxz6Wu5VUEzHPXZ8tzmnn DSDDig2hQflHYmbeim3/DWv4ShOj4pGOtap/rycoMuBpDJ3CEyuDxAThUBrgvHjQmgAY 4AvMb3SQIXjqJzL3YqtwewZl4mtBQowetdxlOT92sTctrU4waihNyAjmXh7LpmyUXUnh 86FiRakgiCe0gJXOWeEc1YWioY9T+NO6yyrDibGhEP88AkCy7Af5vMBr8LeEuMq0N1B6 IezQ==
X-Gm-Message-State	ALoCoQmOixv7KfiOhsXfWX6rnCe+4LVL6vCPw0TeZRlnrWOTKduB8zVHoWsvaYEn7d7cWayQN9ZO
X-Received	by 10.107.128.30 with SMTP id b30mr21767718iod.84.1433792509714; Mon, 08 Jun 2015 12:41:49 -0700 (PDT)
X-X-Sender	rientjes@chino.kir.corp.google.com
User-Agent	Alpine 2.10 (DEB 1266 2009-07-14)
MIME-Version	1.0
Content-Type	TEXT/PLAIN; charset=US-ASCII
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	32
Organization	linux.* mail to news gateway
X-Original-Cc	Michal Hocko <mhocko@suse.cz>, Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
X-Original-Date	Mon, 8 Jun 2015 12:41:48 -0700 (PDT)
X-Original-Message-ID	<alpine.DEB.2.10.1506081237350.13272@chino.kir.corp.google.com>
X-Original-References	<1433235187-32673-1-git-send-email-mhocko@suse.cz> <alpine.DEB.2.10.1506041557070.16555@chino.kir.corp.google.com> <557187F9.8020301@gmail.com> <alpine.DEB.2.10.1506081059200.10521@chino.kir.corp.google.com> <5575E5E6.20908@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1160742

Show key headers only | View raw

On Mon, 8 Jun 2015, Austin S Hemmelgarn wrote:

> I believe so (haven't actually read the patch itself, just the changelog),
> although it is only a change for certain configurations to a very specific and
> (I hope infrequently) used piece of functionality. Like I said above, if I
> wanted to crash my system, I'd be using sysrq-c; and if I'm using sysrq-f, I
> want _some_ task to die _now_.
> 

This patch is not a functional change, so I don't interpret your feedback 
as any support of it being merged.

That said, you raise an interesting point of whether sysrq+f should ever 
trigger a panic due to panic_on_oom.  The case can be made that it should 
ignore panic_on_oom and require the use of another sysrq to panic the 
machine instead.  Sysrq+f could then be used to oom kill a process, 
regardless of panic_on_oom, and the panic only occurs if userspace did not 
trigger the kill or the kill itself will fail.

I think we should pursue that direction.

This patch also changes the text which is output to the kernel log on 
panic, which we use to parse for machines that have crashed due to no 
killable memcg processes, so NACK on this patch.  There's also no reason 
to add more source code to try to make things cleaner when it just 
obfuscates the oom killer code more than it needs to (we don't need to 
optimize or have multiple entry points).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] oom: split out forced OOM killer Austin S Hemmelgarn <ahferroin7@gmail.com> - 2015-06-08 21:00 +0200
  Re: [PATCH] oom: split out forced OOM killer David Rientjes <rientjes@google.com> - 2015-06-08 21:50 +0200

csiph-web