Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1162948

Re: [PATCH] gpio / ACPI: Return -EPROBE_DEFER if the gpiochip was not found

Show all headers | View raw

Rafael J. Wysocki wrote:
> On Wednesday, June 10, 2015 04:05:05 PM Mika Westerberg wrote:
> > If a driver requests a GPIO described in its _CRS but the GPIO host
> > controller (gpiochip) driver providing the GPIO has not been loaded yet
> > acpi_get_gpiod() returns -ENODEV which causes the calling driver to fail.
> > 
> > If the gpiochip driver is loaded afterwards the driver requesting the GPIO
> > will not notice this.
> > 
> > Better approach is to return -EPROBE_DEFER in such case. Then when the
> > gpiochip driver appears the driver requesting the GPIO will be probed
> > again. This also aligns ACPI GPIO lookup code closer to DT as it does
> > pretty much the same when no gpiochip driver was found.
> > 
> > Reported-by: Tobias Diedrich <tobiasdiedrich@gmail.com>
> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> 
> Makes sense to me.
> 
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Signed-off-by: Tobias Diedrich <ranma+kernel@tdiedrich.de>

-- 
Tobias						PGP: http://8ef7ddba.uguu.de
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] gpio / ACPI: Return -EPROBE_DEFER if the gpiochip was not found "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-06-11 01:20 +0200
  Re: [PATCH] gpio / ACPI: Return -EPROBE_DEFER if the gpiochip was  not found Tobias Diedrich <ranma+kernel@tdiedrich.de> - 2015-06-11 02:20 +0200

csiph-web