Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1160432

[Patch V4 10/16] xen: check pre-allocated page tables for conflict with memory map

Show all headers | View raw

Check whether the page tables built by the domain builder are at
memory addresses which are in conflict with the target memory map.
If this is the case just panic instead of running into problems
later.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 arch/x86/xen/mmu.c     | 19 ++++++++++++++++---
 arch/x86/xen/setup.c   |  6 ++++++
 arch/x86/xen/xen-ops.h |  1 +
 3 files changed, 23 insertions(+), 3 deletions(-)

diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
index c04e14e..1982617 100644
--- a/arch/x86/xen/mmu.c
+++ b/arch/x86/xen/mmu.c
@@ -116,6 +116,7 @@ static pud_t level3_user_vsyscall[PTRS_PER_PUD] __page_aligned_bss;
 DEFINE_PER_CPU(unsigned long, xen_cr3);	 /* cr3 stored as physaddr */
 DEFINE_PER_CPU(unsigned long, xen_current_cr3);	 /* actual vcpu cr3 */
 
+static phys_addr_t xen_pt_base, xen_pt_size __initdata;
 
 /*
  * Just beyond the highest usermode address.  STACK_TOP_MAX has a
@@ -1998,7 +1999,9 @@ void __init xen_setup_kernel_pagetable(pgd_t *pgd, unsigned long max_pfn)
 		check_pt_base(&pt_base, &pt_end, addr[i]);
 
 	/* Our (by three pages) smaller Xen pagetable that we are using */
-	memblock_reserve(PFN_PHYS(pt_base), (pt_end - pt_base) * PAGE_SIZE);
+	xen_pt_base = PFN_PHYS(pt_base);
+	xen_pt_size = (pt_end - pt_base) * PAGE_SIZE;
+	memblock_reserve(xen_pt_base, xen_pt_size);
 	/* protect xen_start_info */
 	memblock_reserve(__pa(xen_start_info), PAGE_SIZE);
 	/* Revector the xen_start_info */
@@ -2074,11 +2077,21 @@ void __init xen_setup_kernel_pagetable(pgd_t *pgd, unsigned long max_pfn)
 			  PFN_DOWN(__pa(initial_page_table)));
 	xen_write_cr3(__pa(initial_page_table));
 
-	memblock_reserve(__pa(xen_start_info->pt_base),
-			 xen_start_info->nr_pt_frames * PAGE_SIZE);
+	xen_pt_base = __pa(xen_start_info->pt_base);
+	xen_pt_size = xen_start_info->nr_pt_frames * PAGE_SIZE;
+
+	memblock_reserve(xen_pt_base, xen_pt_size);
 }
 #endif	/* CONFIG_X86_64 */
 
+void __init xen_pt_check_e820(void)
+{
+	if (xen_is_e820_reserved(xen_pt_base, xen_pt_size)) {
+		xen_raw_console_write("Xen hypervisor allocated page table memory conflicts with E820 map\n");
+		BUG();
+	}
+}
+
 static unsigned char dummy_mapping[PAGE_SIZE] __page_aligned_bss;
 
 static void xen_set_fixmap(unsigned idx, phys_addr_t phys, pgprot_t prot)
diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
index 9bd3f35..3fca9c1 100644
--- a/arch/x86/xen/setup.c
+++ b/arch/x86/xen/setup.c
@@ -802,6 +802,12 @@ char * __init xen_memory_setup(void)
 		BUG();
 	}
 
+	/*
+	 * Check for a conflict of the hypervisor supplied page tables with
+	 * the target E820 map.
+	 */
+	xen_pt_check_e820();
+
 	xen_reserve_xen_mfnlist();
 
 	/*
diff --git a/arch/x86/xen/xen-ops.h b/arch/x86/xen/xen-ops.h
index 3f1669c..553abd8 100644
--- a/arch/x86/xen/xen-ops.h
+++ b/arch/x86/xen/xen-ops.h
@@ -35,6 +35,7 @@ void xen_build_mfn_list_list(void);
 void xen_setup_machphys_mapping(void);
 void xen_setup_kernel_pagetable(pgd_t *pgd, unsigned long max_pfn);
 void xen_reserve_top(void);
+void __init xen_pt_check_e820(void);
 
 void xen_mm_pin_all(void);
 void xen_mm_unpin_all(void);
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[Patch V4 00/16] xen: support pv-domains larger than 512GB Juergen Gross <jgross@suse.com> - 2015-06-08 14:10 +0200
  [Patch V4 06/16] xen: split counting of extra memory pages from remapping Juergen Gross <jgross@suse.com> - 2015-06-08 14:10 +0200
  [Patch V4 11/16] xen: check for initrd conflicting with e820 map Juergen Gross <jgross@suse.com> - 2015-06-08 14:10 +0200
  [Patch V4 09/16] xen: check for kernel memory conflicting with memory layout Juergen Gross <jgross@suse.com> - 2015-06-08 14:10 +0200
  [Patch V4 01/16] xen: sync with xen headers Juergen Gross <jgross@suse.com> - 2015-06-08 14:10 +0200
  [Patch V4 16/16] xen: remove no longer needed p2m.h Juergen Gross <jgross@suse.com> - 2015-06-08 14:10 +0200
  [Patch V4 14/16] xen: move p2m list if conflicting with e820 map Juergen Gross <jgross@suse.com> - 2015-06-08 14:10 +0200
    Re: [Xen-devel] [Patch V4 14/16] xen: move p2m list if conflicting  with e820 map David Vrabel <david.vrabel@citrix.com> - 2015-06-11 13:10 +0200
  [Patch V4 07/16] xen: check memory area against e820 map Juergen Gross <jgross@suse.com> - 2015-06-08 14:10 +0200
  [Patch V4 10/16] xen: check pre-allocated page tables for conflict with memory map Juergen Gross <jgross@suse.com> - 2015-06-08 14:10 +0200
  [Patch V4 15/16] xen: allow more than 512 GB of RAM for 64 bit pv-domains Juergen Gross <jgross@suse.com> - 2015-06-08 14:10 +0200
  [Patch V4 02/16] xen: save linear p2m list address in shared info structure Juergen Gross <jgross@suse.com> - 2015-06-08 14:10 +0200
  [Patch V4 08/16] xen: find unused contiguous memory area Juergen Gross <jgross@suse.com> - 2015-06-08 14:10 +0200
  [Patch V4 13/16] xen: add explicit memblock_reserve() calls for special pages Juergen Gross <jgross@suse.com> - 2015-06-08 14:10 +0200
  [Patch V4 12/16] mm: provide early_memremap_ro to establish read-only mapping Juergen Gross <jgross@suse.com> - 2015-06-08 14:10 +0200

csiph-web