RE: [RESEND PATCH V4 1/1] input: misc: da9063: OnKey driver

From	"Opensource [Steve Twiss]" <stwiss.opensource@diasemi.com>
Newsgroups	linux.kernel
Subject	RE: [RESEND PATCH V4 1/1] input: misc: da9063: OnKey driver
Date	2015-06-08 13:40 +0200
Message-ID	<pz3zj-5GR-3@gated-at.bofh.it> (permalink)
References	<pxBc6-7pK-17@gated-at.bofh.it> <pxBc6-7pK-23@gated-at.bofh.it> <py44r-7r7-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 05 June 2015 18:50 Dmitry Torokhov wrote:

> Subject: Re: [RESEND PATCH V4 1/1] input: misc: da9063: OnKey driver
> On Thu, Jun 04, 2015 at 12:02:32PM +0100, S Twiss wrote:
> > From: Steve Twiss <stwiss.opensource@diasemi.com>
> >
> > Add OnKey driver support for DA9063
> >
> > Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>
> >
> > ---
> > The changes made in PATCH V3 have been taken from the DA9062 OnKey review
> > thread. Please see https://lkml.org/lkml/2015/4/29/406 for more information
> > on this.
> >
> > Version History
> >
> > Changes in V4
> >  - No change, just a resend.
> 
> Sorry for the delay.
> 
> I took the liberty of rearranging the code a bit and converting it to
> devm* fully, does the version below still work for you?
> 

Hi Dmitry,

No problem. Thank you for getting back to me and for taking the time to work
through this code.

Everything looks fine for me thank you.

Tested-by: Steve Twiss <stwiss.opensource@diasemi.com>

I see now: in future I will make use of the devm_add_action() and use the devm*
properly & your changes have simplified the error handling and negated the need
for a .remove function. The devm release cleans up in reverse -- preserving
the free_irq() and cancel_delayed_work_sync() ordering ...

Regards,
Steve.

CC: Adam Ward <adam.ward.opensource@diasemi.com>

[...]

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RESEND PATCH V4 0/1]  Add OnKey support for DA9063 S Twiss <stwiss.opensource@diasemi.com> - 2015-06-04 13:10 +0200
  [RESEND PATCH V4 1/1] input: misc: da9063: OnKey driver S Twiss <stwiss.opensource@diasemi.com> - 2015-06-04 13:10 +0200
    RE: [RESEND PATCH V4 1/1] input: misc: da9063: OnKey driver "Opensource [Steve Twiss]" <stwiss.opensource@diasemi.com> - 2015-06-08 13:40 +0200

csiph-web