Re: [PATCH] drm/i915: Properly initialize SDVO analog connectors

From	Jani Nikula <jani.nikula@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drm/i915: Properly initialize SDVO analog connectors
Date	2015-06-08 13:00 +0200
Message-ID	<pz2WC-4Hr-15@gated-at.bofh.it> (permalink)
References	<pyyFb-2Ah-5@gated-at.bofh.it> <pz0Br-1lC-3@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Mon, 08 Jun 2015, Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> wrote:
> In the commit below, I missed the connector allocation in the function
> intel_sdvo_analog_init(), leading to those connectors to have a NULL
> state pointer.
>
> commit 08d9bc920d465bbbbd762cac9383249c19bf69a2
> Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> Date:   Fri Apr 10 10:59:10 2015 +0300
>
>     drm/i915: Allocate connector state together with the connectors
>
> Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>

Pushed to drm-intel-fixes, thanks for the patch and testing.

BR,
Jani.



> ---
>  drivers/gpu/drm/i915/intel_sdvo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c
> index d24ef75..aa2fd75 100644
> --- a/drivers/gpu/drm/i915/intel_sdvo.c
> +++ b/drivers/gpu/drm/i915/intel_sdvo.c
> @@ -2554,7 +2554,7 @@ intel_sdvo_analog_init(struct intel_sdvo *intel_sdvo, int device)
>  
>  	DRM_DEBUG_KMS("initialising analog device %d\n", device);
>  
> -	intel_sdvo_connector = kzalloc(sizeof(*intel_sdvo_connector), GFP_KERNEL);
> +	intel_sdvo_connector = intel_sdvo_connector_alloc();
>  	if (!intel_sdvo_connector)
>  		return false;
>  
> -- 
> 2.1.0
>

-- 
Jani Nikula, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: git pull] drm for v4.1-rc1 Ville Syrjälä <ville.syrjala@linux.intel.com> - 2015-06-07 02:00 +0200
  Re: git pull] drm for v4.1-rc1 Stefan Lippers-Hollmann <s.l-h@gmx.de> - 2015-06-07 04:40 +0200
    Re: git pull] drm for v4.1-rc1 Stefan Lippers-Hollmann <s.l-h@gmx.de> - 2015-06-08 12:30 +0200
    [Fwd: Re: [PATCH] drm/i915: Properly initialize SDVO analog  connectors] Ander Conselvan De Oliveira <conselvan2@gmail.com> - 2015-06-08 12:40 +0200
    Re: [PATCH] drm/i915: Properly initialize SDVO analog connectors Jani Nikula <jani.nikula@intel.com> - 2015-06-08 13:00 +0200

csiph-web