Re: [PATCH 4/6] ARM: dts; pxa: add embedded pxa camera capture interface

From	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/6] ARM: dts; pxa: add embedded pxa camera capture interface
Date	2015-06-07 00:10 +0200
Message-ID	<pyurT-4Pc-11@gated-at.bofh.it> (permalink)
References	<pytFv-3E8-3@gated-at.bofh.it> <pytFw-3E8-11@gated-at.bofh.it>
Organization	Cogent Embedded

Show all headers | View raw

Hello.

On 06/07/2015 12:09 AM, Robert Jarzmik wrote:

> The pxa27x SoCs have an embedded camera host controller. Add the
> description to the family description.

> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> ---
>   arch/arm/boot/dts/pxa27x.dtsi | 17 +++++++++++++++++
>   1 file changed, 17 insertions(+)

> diff --git a/arch/arm/boot/dts/pxa27x.dtsi b/arch/arm/boot/dts/pxa27x.dtsi
> index 506db86..9ebfd7f 100644
> --- a/arch/arm/boot/dts/pxa27x.dtsi
> +++ b/arch/arm/boot/dts/pxa27x.dtsi
> @@ -77,6 +77,23 @@
>   			clocks = <&clks CLK_KEYPAD>;
>   			status = "disabled";
>   		};
> +
> +		pxa_camera: pxa_camera@50000000 {

    The ePAPR standard has something to say about the node naming:
"The name of a node should be somewhat generic, reflecting the function of the 
device and not its precise programming model." So I'd suggest "video@50000000" 
instead...

[...]

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/6] ARM: dts; pxa: add embedded pxa camera capture interface Robert Jarzmik <robert.jarzmik@free.fr> - 2015-06-06 23:20 +0200
  Re: [PATCH 4/6] ARM: dts; pxa: add embedded pxa camera capture interface Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-06-07 00:10 +0200

csiph-web