Re: [PATCH v3 2/2] gpio_wdt: Add option for early registration

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Paul Bolle <pebolle@tiscali.nl>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 2/2] gpio_wdt: Add option for early registration
Date	Sat, 06 Jun 2015 16:20:02 +0200
Message-ID	<pyn74-2tM-13@gated-at.bofh.it> (permalink)
References	<pyh1D-1QY-3@gated-at.bofh.it> <pyh1E-1QY-19@gated-at.bofh.it> <pyjd8-5et-7@gated-at.bofh.it> <pylRD-tV-1@gated-at.bofh.it>
X-Original-To	Valentin Rothberg <valentinrothberg@gmail.com>
Content-Type	text/plain; charset="UTF-8"
X-Mailer	Evolution 3.10.4 (3.10.4-4.fc20)
MIME-Version	1.0
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	28
Organization	linux.* mail to news gateway
X-Original-Cc	Jean-Baptiste Theou <jtheou@adeneo-embedded.us>, Wim Van Sebroeck <wim@iguana.be>, Guenter Roeck <linux@roeck-us.net>, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Sat, 06 Jun 2015 16:11:18 +0200
X-Original-Message-ID	<1433599878.10861.82.camel@x220>
X-Original-References	<1433576786-14947-1-git-send-email-jtheou@adeneo-embedded.us> <1433576786-14947-2-git-send-email-jtheou@adeneo-embedded.us> <1433584986.10861.46.camel@x220> <20150606125611.GA16930@nebuchadnezzar>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1159912

Show key headers only | View raw

On Sat, 2015-06-06 at 14:56 +0200, Valentin Rothberg wrote:
> On Sat, Jun 06, 2015 at 12:03:06PM +0200, Paul Bolle wrote:
> > On Sat, 2015-06-06 at 00:46 -0700, Jean-Baptiste Theou wrote:
> > > +#ifdef GPIO_WATCHDOG_ARCH_INITCALL
> > 
> > You meant
> >     #ifdef CONFIG_GPIO_WATCHDOG_ARCH_INITCALL
> > 
> > Please use scripts/checkkconfigsymbols.py.
> 
> checkkconfigsymbols.py only checks CONFIG_ prefix symbols.  Since this
> prefix is missing here, the script would not complain.

Of course. Thanks for correcting me.

> But that's an interesting case and worth checking for.

Perhaps. Depends on the amount of false positives that such checks would
trigger, I'd say.


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 2/2] gpio_wdt: Add option for early registration Valentin Rothberg <valentinrothberg@gmail.com> - 2015-06-06 15:00 +0200
  Re: [PATCH v3 2/2] gpio_wdt: Add option for early registration Paul Bolle <pebolle@tiscali.nl> - 2015-06-06 16:20 +0200

csiph-web