Re: [PATCH v5 1/2] ARM: dts: vfxxx: Add OCOTP and OCROM nodes

From	Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 1/2] ARM: dts: vfxxx: Add OCOTP and OCROM nodes
Date	2015-06-06 14:10 +0200
Message-ID	<pyl5h-7YP-49@gated-at.bofh.it> (permalink)
References	<pxW6S-4jT-9@gated-at.bofh.it> <pxW6S-4jT-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Fri, Jun 05, 2015 at 02:52:37PM +0530, Sanchayan Maity wrote:
> Add a device tree node for the On-Chip One Time Programmable
> Controller (OCOTP) and the On-Chip ROM.
> 
> Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> ---
>  arch/arm/boot/dts/vfxxx.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
> index 2f4b04d..ed9b6b8 100644
> --- a/arch/arm/boot/dts/vfxxx.dtsi
> +++ b/arch/arm/boot/dts/vfxxx.dtsi
> @@ -56,6 +56,13 @@
>  		compatible = "simple-bus";
>  		interrupt-parent = <&mscm_ir>;
>  		ranges;
> +		ocotp-cfg = <&ocotp 0x410 0x420>;
> +		rom-revision = <&ocrom 0x80>;
> +
> +		ocrom: ocrom {
> +			compatible = "fsl,vf610-ocrom", "syscon";
> +			reg = <0x00000000 0x18000>;
> +		};

Shouldn't that use the new nvmem framework currently being discussed,
instead of defining custom bindings?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v5 1/2] ARM: dts: vfxxx: Add OCOTP and OCROM nodes Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-06-06 14:10 +0200

csiph-web