Re: [PATCH v4 3/9] dax: drop size parameter to ->direct_access()

Path	csiph.com!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From	Matthew Wilcox <willy@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 3/9] dax: drop size parameter to ->direct_access()
Date	Sat, 06 Jun 2015 13:40:03 +0200
Message-ID	<pykCf-7av-43@gated-at.bofh.it> (permalink)
References	<py7lE-4cR-3@gated-at.bofh.it> <py7lF-4cR-25@gated-at.bofh.it>
X-Original-To	Dan Williams <dan.j.williams@intel.com>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.13,563,1427785200"; d="scan'208";a="738267575"
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	24
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, axboe@kernel.dk, boaz@plexistor.com, david@fromorbit.com, linux-arch@vger.kernel.org, arnd@arndb.de, ross.zwisler@linux.intel.com, linux-nvdimm@lists.01.org, benh@kernel.crashing.org, linux-fsdevel@vger.kernel.org, heiko.carstens@de.ibm.com, hch@lst.de, tj@kernel.org, paulus@samba.org, hpa@zytor.com, schwidefsky@de.ibm.com, akpm@linux-foundation.org, torvalds@linux-foundation.org, mingo@kernel.org
X-Original-Date	Sat, 6 Jun 2015 07:37:40 -0400
X-Original-Message-ID	<20150606113739.GH2729@linux.intel.com>
X-Original-References	<20150605205052.20751.77149.stgit@dwillia2-desk3.amr.corp.intel.com> <20150605211918.20751.21557.stgit@dwillia2-desk3.amr.corp.intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1159878

Show key headers only | View raw

On Fri, Jun 05, 2015 at 05:19:18PM -0400, Dan Williams wrote:
> None of the implementations currently use it.  The common
> bdev_direct_access() entry point handles all the size checks before
> calling ->direct_access().

Interesting.  The reason it was still there, even after moving all
the size checks to bdev_direct_access() was to support the case of a
hypothetical future driver that exposed several discontiguous ranges as
a single block device.

But we don't actually need it for that, as long as the discontiguous
ranges are relatively large.  As the comment you deleted noted, the brd
driver could do this, but I certainly haven't taken the time to figure
out whether it'd be a performance win if the pages "just happen" to line
up right.

So I don't think I'm objecting to this patch (except that it conflicts
textually with my dynamic mapping patch that you've seen but hasn't been
posted publically yet).  Just something to think about.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v4 3/9] dax: drop size parameter to ->direct_access() Matthew Wilcox <willy@linux.intel.com> - 2015-06-06 13:40 +0200

csiph-web