Re: [PATCH 1/3] acpi: Fix acpi_map_pxm_to_node() to handle numa_off

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Toshi Kani <toshi.kani@hp.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] acpi: Fix acpi_map_pxm_to_node() to handle numa_off
Date	Sat, 06 Jun 2015 02:40:01 +0200
Message-ID	<pyajv-jZ-9@gated-at.bofh.it> (permalink)
References	<px52x-1bs-3@gated-at.bofh.it> <px52x-1bs-5@gated-at.bofh.it>
X-Original-To	rjw@rjwysocki.net
Content-Type	text/plain; charset="UTF-8"
X-Mailer	Evolution 3.10.4 (3.10.4-4.fc20)
MIME-Version	1.0
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	43
Organization	linux.* mail to news gateway
X-Original-Cc	dan.j.williams@intel.com, linux-acpi@vger.kernel.org, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org
X-Original-Date	Fri, 05 Jun 2015 18:33:38 -0600
X-Original-Message-ID	<1433550818.23540.198.camel@misato.fc.hp.com>
X-Original-References	<1433291212-23367-1-git-send-email-toshi.kani@hp.com> <1433291212-23367-2-git-send-email-toshi.kani@hp.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1159796

Show key headers only | View raw

On Tue, 2015-06-02 at 18:26 -0600, Toshi Kani wrote:
> When numa_off is set, NUMA is turned off and node 0 is the only
> valid node on the system.  The kernel skips parsing ACPI SRAT
> table in this case.
> 
> Change acpi_map_pxm_to_node() to always return 0 when numa_off
> is set.  Also move the range check of a proximity ID from
> acpi_get_node() to acpi_map_pxm_to_node() after the numa_off
> check.  This keeps the interfaces to return 0 regardless of
> proximity ID values.
> 
> Signed-off-by: Toshi Kani <toshi.kani@hp.com>
> ---
>  drivers/acpi/numa.c |   12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/acpi/numa.c b/drivers/acpi/numa.c
> index 1333cbdc..4898082 100644
> --- a/drivers/acpi/numa.c
> +++ b/drivers/acpi/numa.c
> @@ -70,7 +70,15 @@ static void __acpi_map_pxm_to_node(int pxm, int node)
>  
>  int acpi_map_pxm_to_node(int pxm)
>  {
> -	int node = pxm_to_node_map[pxm];
> +	int node;
> +
> +	if (numa_off)
> +		return 0;

I found an issue in this patch.  numa_off is only defined in x86, but
this numa.c (ACPI_NUMA) can be enabled on x86 and IA64.  I will fix or
drop it in the next version.

Thanks,
-Toshi


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] acpi: Fix acpi_map_pxm_to_node() to handle numa_off Toshi Kani <toshi.kani@hp.com> - 2015-06-03 02:50 +0200
  Re: [PATCH 1/3] acpi: Fix acpi_map_pxm_to_node() to handle numa_off Toshi Kani <toshi.kani@hp.com> - 2015-06-06 02:40 +0200

csiph-web