Re: metag test failure in -next due to commit 'module: relocate module_init from init.h to module.h'

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Guenter Roeck <linux@roeck-us.net>
Newsgroups	linux.kernel
Subject	Re: metag test failure in -next due to commit 'module: relocate module_init from init.h to module.h'
Date	Sat, 06 Jun 2015 02:40:01 +0200
Message-ID	<pyajv-jZ-11@gated-at.bofh.it> (permalink)
References	<py6IV-34D-9@gated-at.bofh.it> <py7vj-4uN-15@gated-at.bofh.it>
X-Original-To	James Hogan <james.hogan@imgtec.com>, Paul Gortmaker <paul.gortmaker@windriver.com>
Dkim-Signature	v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=roeck-us.net; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Subject:CC:To:MIME-Version:From:Date:Message-ID; bh=0fsqmEvC9A3JdmkQlFD06o8Xq2iLcUK5zsBcSLrbHIk=; b=IooCE52AeeNbi9QXEjewlgErBz1sN6VG2GonXa00rA0Xbsw/4iSgplgkDOsPVehKqKDiWDJVytav3/O7V9RXpygBT77yOi1TvZVzD9bSm4a9WpEbMxitq6VorLCKxA4CWZo0LqBPfjsgzsCZo9JeWXBf9IIvx/xUcG5+W1oyuNk=;
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding	8bit
X-Authenticated_Sender	linux@roeck-us.net
X-Outgoing-Spam-Status	No, score=-1.0
X-Antiabuse	This header was added to track abuse, please include it with any abuse report
X-Antiabuse	Primary Hostname - bh-25.webhostbox.net
X-Antiabuse	Original Domain - vger.kernel.org
X-Antiabuse	Originator/Caller UID/GID - [47 12] / [47 12]
X-Antiabuse	Sender Address Domain - roeck-us.net
X-Get-Message-Sender-Via	bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	53
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, linux-metag@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jslaby@suse.cz>
X-Original-Date	Fri, 05 Jun 2015 17:39:13 -0700
X-Original-Message-ID	<55724131.9040900@roeck-us.net>
X-Original-References	<20150605204055.GA981@roeck-us.net> <20150605213900.GA30510@jhogan-linux.le.imgtec.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1159797

Show key headers only | View raw

On 06/05/2015 02:39 PM, James Hogan wrote:
[ ... ]
>
>  From e12856c559d7dff2ad4f6497996610e12e7c7e2d Mon Sep 17 00:00:00 2001
> From: James Hogan <james.hogan@imgtec.com>
> Date: Fri, 5 Jun 2015 22:17:18 +0100
> Subject: [PATCH] tty/metag_da: Avoid module_init/module_exit
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> The metag_da TTY driver can't get built as a module at the moment, but
> it still uses module_init() and module_exit(). Those macros are moving
> to module.h which isn't included by metag_da.c, which will result in the
> following build warnings (remarkably no build errors) and an apparent
> failure to boot as the TTY driver won't be loaded.
>
> drivers/tty/metag_da.c:660: warning: data definition has no type or storage class
> drivers/tty/metag_da.c:660: warning: type defaults to ‘int’ in declaration of ‘module_init’
> drivers/tty/metag_da.c:660: warning: parameter names (without types) in function declaration
> drivers/tty/metag_da.c:661: warning: data definition has no type or storage class
> drivers/tty/metag_da.c:661: warning: type defaults to ‘int’ in declaration of ‘module_exit’
> drivers/tty/metag_da.c:661: warning: parameter names (without types) in function declaration
> drivers/tty/metag_da.c:572: warning: ‘dashtty_init’ defined but not used
> drivers/tty/metag_da.c:645: warning: ‘dashtty_exit’ defined but not used
> drivers/tty/metag_da.c In function ‘dash_console_write’:
> drivers/tty/metag_da.c:670 : warning: passing argument 4 of ‘chancall’ discards qualifiers from pointer target type
>
> Instead of just adding the module.h include, now would be a good time to
> remove the use of these macros, replacing the module_init with
> device_initcall, and removing the exit function altogether since it
> isn't needed. If module support is added later the code can always be
> resurrected.
>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jslaby@suse.cz>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Cc: linux-metag@vger.kernel.org

Yes, that does the trick.

Tested-by: Guenter Roeck <linux@roeck-us.net>

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: metag test failure in -next due to commit 'module: relocate module_init  from init.h to module.h' Guenter Roeck <linux@roeck-us.net> - 2015-06-06 02:40 +0200
  Re: metag test failure in -next due to commit 'module: relocate  module_init from init.h to module.h' Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-06-08 00:20 +0200

csiph-web