Re: [PATCH] net: moxa: fix TX overrun memory leak

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: moxa: fix TX overrun memory leak
Date	2015-06-08 04:30 +0200
Message-ID	<pyUZ4-1qK-5@gated-at.bofh.it> (permalink)
References	<py0av-1Ik-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Jonas Jensen <jonas.jensen@gmail.com>
Date: Fri,  5 Jun 2015 15:46:18 +0200

>  	desc = priv->tx_desc_base + (TX_REG_DESC_SIZE * tx_head);
>  
> -	spin_lock_irq(&priv->txlock);
> +	if (CIRC_SPACE(tx_head, tx_tail, TX_DESC_NUM) == 0) {
> +		priv->stats.tx_dropped++;
> +		goto out_unlock;
> +	}

You can't do this.

Whatever code creates this condition _must_ stop the TX queue
so that the core netdevice transmit layer does not call your
transmit method.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] net: moxa: fix TX overrun memory leak David Miller <davem@davemloft.net> - 2015-06-08 04:30 +0200

csiph-web