Re: [PATCH] modules: CONFIG_MODULE_COMPRESS: add hint that userspace support may easily be missing.

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Lucas De Marchi <lucas.de.marchi@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] modules: CONFIG_MODULE_COMPRESS: add hint that userspace support may easily be missing.
Date	Sun, 07 Jun 2015 08:20:01 +0200
Message-ID	<pyC65-7F5-3@gated-at.bofh.it> (permalink)
References	<pwdlw-6dE-7@gated-at.bofh.it> <pwrRw-297-5@gated-at.bofh.it> <pxkNX-81W-9@gated-at.bofh.it> <pxsBQ-2wB-7@gated-at.bofh.it> <pxtex-3FV-1@gated-at.bofh.it> <pxJW1-3gL-11@gated-at.bofh.it>
X-Original-To	Rusty Russell <rusty@rustcorp.com.au>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=rq19+Pkpw08EtX3JKgHGjuYz42ZwMPdF/qCnx4V3elc=; b=1Imk9OVow2oSBr5cBw+b1CYVVLnSe1klRGkjEO2nDLMhLLx89QimVspl6veWqonmTi F/NWAP1v2l9yZ8QMs47wifgwP9xQyZ6YqOFAMBlspjxqmun3V1CXDINBMuKjhfnBMV1Z iE4Mv0M6p9iZAsPE0fmCZnCwML1nioVxEJzZy6aY8eZ0IaXwBrFZvPJOCuACsUjssKW/ XpoDIx/7JUl9qa/3X/JiJY5oemn+J/KiGIjSEKk+Zs578Qb3ixBUtvOxdjKPwDtqm1cl MhkFHTEnccPGHUM3JEbQkf+lw7y63thaYLvd0ul/Z7gtu83a01JM3BF//g12rfH8sAuv 4usA==
X-Received	by 10.182.143.5 with SMTP id sa5mr9519490obb.62.1433657953886; Sat, 06 Jun 2015 23:19:13 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	43
Organization	linux.* mail to news gateway
X-Original-Cc	Andreas Mohr <andi@lisas.de>, Andrew Morton <akpm@linux-foundation.org>, Bertrand Jacquin <beber@meleeweb.net>, "Marco d'Itri" <md@linux.it>, linux-modules <linux-modules@vger.kernel.org>, lkml <linux-kernel@vger.kernel.org>, Jon Masters <jcm@redhat.com>
X-Original-Date	Sun, 7 Jun 2015 03:18:53 -0300
X-Original-Message-ID	<CAKi4VAJpRGiTdOouP8M1eZtw5eZwRE6tLRqSLApRixEsVJv+OA@mail.gmail.com>
X-Original-References	<20150531152932.GA16337@rhlx01.hs-esslingen.de> <87r3pwgd0b.fsf@rustcorp.com.au> <CAKi4VAJfhM0UMOmFkQ40RW5gJGKch8AH8QEvuiYtj93O+YTNwA@mail.gmail.com> <87h9qouuny.fsf@rustcorp.com.au> <CAKi4VA+4mFsg7VCqr+3wd4dCqUtCW02YP7KYmVYF0prH5bet0g@mail.gmail.com> <87zj4fte9r.fsf@rustcorp.com.au>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1159997

Show key headers only | View raw

On Thu, Jun 4, 2015 at 5:22 PM, Rusty Russell <rusty@rustcorp.com.au> wrote:
> Lucas De Marchi <lucas.de.marchi@gmail.com> writes:
>>> +         gzip and xz (but doesn't by default, at least as of version 18!).
>>
>> This is pretty much misleading. There's no such a default option. It's
>> like saying kernel doesn't support feature X, Y or Z by default
>> because make defconfig doesn't turn them on.
>
> Nobody except Linus expects a defconfig to boot.
>
> I expect ./configure to give me a working tool; these *are* defaults,
> and setting them *is* your responsibility as author.  When it became an
> in-kernel option rather than some weird distro thing, the old default
> was wrong.
>
> ... Though I hadn't realized that Marco had deliberately decided to
> leave support off.  Surprising, since liblzma and libz seem required on
> Debian anyway.

As you can see, no default to something else will make distros adopt that.
I long ago decided not to provide a default for compression because it's
clearly not agreed upon.  Instead it's everything disabled and the
distro chooses what it wants to support.

So if you think the configuration for your distro should be something else,
convince the maintainer to change it showing why it's important.

FYI I'm adding in kmod the ability to query the flags used during build. So
now we have:

$ ./tools/kmod --version
kmod version 20
+XZ +ZLIB -EXPERIMENTAL

This will be present in kmod 21

-- 
Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] modules: CONFIG_MODULE_COMPRESS: add hint that userspace support may easily be missing. Rusty Russell <rusty@rustcorp.com.au> - 2015-06-04 04:00 +0200
  Re: [PATCH] modules: CONFIG_MODULE_COMPRESS: add hint that userspace  support may easily be missing. Lucas De Marchi <lucas.de.marchi@gmail.com> - 2015-06-07 08:20 +0200

csiph-web