Re: [PATCH v3] seccomp: add ptrace options for suspend/resume

From	Oleg Nesterov <oleg@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] seccomp: add ptrace options for suspend/resume
Date	2015-06-06 01:50 +0200
Message-ID	<py9x8-7AM-9@gated-at.bofh.it> (permalink)
References	<py7lG-4cR-39@gated-at.bofh.it> <py7OG-51D-1@gated-at.bofh.it> <py7Ym-5sK-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 06/05, Tycho Andersen wrote:
>
> right thing to do, just leave out the definition of
> may_suspend_seccomp all together, or add in another if defined() in
> the header?

Just declare it unconditionally in .h. The kernel relies on this kind
of dead-code elimination anyway. For example, please look at
"extern void __put_user_bad(void)" in uaccess.h.

IOW,

	extern void undefined_func(void);

	if (0)
		undefined_func();

should be safe.

> Maybe we will get rid of this pesky function all together though...

Yes ;)

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v3] seccomp: add ptrace options for suspend/resume Oleg Nesterov <oleg@redhat.com> - 2015-06-06 01:50 +0200

csiph-web