Re: [PATCH RFC v3 2/3] crypto: RSA: KEYS: convert rsa and public key to new PKE API

From	Herbert Xu <herbert@gondor.apana.org.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH RFC v3 2/3] crypto: RSA: KEYS: convert rsa and public key to new PKE API
Date	2015-06-04 09:00 +0200
Message-ID	<pxxia-1jd-21@gated-at.bofh.it> (permalink)
References	<pxpDY-6H6-15@gated-at.bofh.it> <pxpDY-6H6-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 03, 2015 at 03:44:14PM -0700, Tadeusz Struk wrote:
> Change the existing rsa and public key code to integrate it
> with the new Public Key Encryption API.
> 
> Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>

I'd like to see this split into multiple patches.  First of all
the new crypto_akcipher implementation should coexist with the
existing code.  That way the exiting users can be converted over
one-by-one.

Also you should implement the crypto_akcipher completely before
converting anybody over, that means doing encoding/wrapping in
addition to the crypto.

That way we don't have to have craziness like converting in and
out of MPI multiple times.

Lastly you should consider adding an MPI helper that writes to
an existing buffer instead of allocating a new one and copying
it over.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH RFC v3 0/3] crypto: Introduce Public Key Encryption API Tadeusz Struk <tadeusz.struk@intel.com> - 2015-06-04 00:50 +0200
  [PATCH RFC v3 1/3] crypto: add PKE API Tadeusz Struk <tadeusz.struk@intel.com> - 2015-06-04 00:50 +0200
    Re: [PATCH RFC v3 1/3] crypto: add PKE API Herbert Xu <herbert@gondor.apana.org.au> - 2015-06-04 09:00 +0200
  [PATCH RFC v3 3/3] crypto: add tests vectors for RSA Tadeusz Struk <tadeusz.struk@intel.com> - 2015-06-04 00:50 +0200
    Re: [PATCH RFC v3 3/3] crypto: add tests vectors for RSA Stephan Mueller <smueller@chronox.de> - 2015-06-04 02:20 +0200
  Re: [PATCH RFC v3 2/3] crypto: RSA: KEYS: convert rsa and public key  to new PKE API Herbert Xu <herbert@gondor.apana.org.au> - 2015-06-04 09:00 +0200

csiph-web