Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1157909

Re: [PATCH v2 1/2] net/xen-netfront: Correct printf format in xennet_get_responses

Show all headers | View raw

On Wed, 2015-06-03 at 17:55 +0100, Julien Grall wrote:
> rx->status is an int16_t, print it using %d rather than %u in order to
> have a meaningful value when the field is negative.
[]
> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
[]
> @@ -733,7 +733,7 @@ static int xennet_get_responses(struct netfront_queue *queue,
>  		if (unlikely(rx->status < 0 ||
>  			     rx->offset + rx->status > PAGE_SIZE)) {
>  			if (net_ratelimit())
> -				dev_warn(dev, "rx->offset: %x, size: %u\n",
> +				dev_warn(dev, "rx->offset: %x, size: %d\n",

If you're going to do this, perhaps it'd be sensible to
also change the %x to %#x or 0x%x so that people don't
mistake offset without an [a-f] for decimal.

>  					 rx->offset, rx->status);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/2] net/xen-netfront: Correct printf format in xennet_get_responses Julien Grall <julien.grall@citrix.com> - 2015-06-03 19:00 +0200
  Re: [PATCH v2 1/2] net/xen-netfront: Correct printf format in  xennet_get_responses Joe Perches <joe@perches.com> - 2015-06-03 19:20 +0200

csiph-web