RE: [lustre-devel] [PATCH v3 6/7] staging:lustre: style cleanups for lib-socket.c

From	"Simmons, James A." <simmonsja@ornl.gov>
Newsgroups	linux.kernel
Subject	RE: [lustre-devel] [PATCH v3 6/7] staging:lustre: style cleanups for lib-socket.c
Date	2015-06-03 19:20 +0200
Message-ID	<pxkuC-7Ey-17@gated-at.bofh.it> (permalink)
References	<pxhZM-3RH-7@gated-at.bofh.it> <pxhZM-3RH-25@gated-at.bofh.it> <pxi9s-43D-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

>On Wed, 2015-06-03 at 10:32 -0400, James Simmons wrote:
>> Handle all the style issues reported by checkpatch.pl.
>> Remove general white spaces, spaces in function calls,
>> etc.
>[]
>> @@ -167,13 +164,14 @@ lnet_ipif_enumerate (char ***namesp)
>>  		if (nalloc * sizeof(*ifr) > PAGE_CACHE_SIZE) {
>>  			toobig = 1;
>>  			nalloc = PAGE_CACHE_SIZE/sizeof(*ifr);
>> -			CWARN("Too many interfaces: only enumerating first %d\n",
>> -			      nalloc);
>> +			CWARN("Too many interfaces: only enumerating "
>> +			      "first %d\n", nalloc);
>
>Please don't split single strings into multiple parts.
>
>For a patch like this it'd be nice to specify that both
>"git diff -w" and scripts/objdiff shows no differences.
>
>Unless it does...

Two patches have mistakes. Should I send a new series or do a in-reply instead.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

RE: [lustre-devel] [PATCH v3 6/7] staging:lustre: style cleanups for  lib-socket.c "Simmons, James A." <simmonsja@ornl.gov> - 2015-06-03 19:20 +0200

csiph-web