Re: [PATCH] tpm: introduce struct tpm_buf

From	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] tpm: introduce struct tpm_buf
Date	2015-06-03 19:10 +0200
Message-ID	<pxkkZ-7sr-67@gated-at.bofh.it> (permalink)
References	(1 earlier) <pwYX7-KM-19@gated-at.bofh.it> <pxg7E-14D-19@gated-at.bofh.it> <pxjyz-6gc-17@gated-at.bofh.it> <pxk1B-6Pj-17@gated-at.bofh.it> <pxk1B-6Pj-15@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Wed, Jun 03, 2015 at 10:48:51AM -0600, Jason Gunthorpe wrote:
> On Wed, Jun 03, 2015 at 07:43:34PM +0300, Jarkko Sakkinen wrote:
> > I realized basically the same what you said here when I refined the
> > patch (read this email after sending v2) :) I decided that align to 8
> > bytes.
> 
> Don't use the __attribute__((align)), use just a u64, the effect is
> identical, and the latter doesn't rely on compiler specific features.

Byte array is otherwise more convenient and this feature is widely used:

$ git grep "__attribute__((aligned" | wc -l
222

I don't see your point here.

> > I don't think the packed attribute is needed here because now I cast
> > the beginning to tpm_input_header, which is a packed struct.
> 
> I ment the attributs could be changed on the tpm_input_header, the buf
> should just be a u64 array..
> 
> Jason

/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH] tpm: introduce struct tpm_buf Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-06-03 14:40 +0200
  Re: [PATCH] tpm: introduce struct tpm_buf Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-06-03 18:20 +0200
    Re: [PATCH] tpm: introduce struct tpm_buf Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-06-03 18:50 +0200
      Re: [PATCH] tpm: introduce struct tpm_buf Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-06-03 19:10 +0200
    Re: [PATCH] tpm: introduce struct tpm_buf Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-06-03 18:50 +0200

csiph-web