Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1157869
| From | Malcolm Priestley <tvboxspy@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] ts2020: Provide DVBv5 API signal strength |
| Date | 2015-06-03 19:10 +0200 |
| Message-ID | <pxkkX-7sr-37@gated-at.bofh.it> (permalink) |
| References | (4 earlier) <puoEq-7J7-21@gated-at.bofh.it> <pv2Vb-8uq-3@gated-at.bofh.it> <pxdW9-6iU-1@gated-at.bofh.it> <pxjRV-6Dp-9@gated-at.bofh.it> <pxk1A-6Pj-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 03/06/15 17:43, Antti Palosaari wrote: > On 06/03/2015 07:37 PM, David Howells wrote: >> Malcolm Priestley <tvboxspy@gmail.com> wrote: >> >>>>> Yes, also, the workqueue appears not to be initialized when using >>>>> the dvb >>>>> attached method. >>>> >>>> I'm not sure what you're referring to. It's initialised in >>>> ts2020_probe() >>>> just after the ts2020_priv struct is allocated - the only place it is >>>> allocated. >>>> >>> ts2020_probe() isn't touched by devices not converted to I2C binding. >> >> Hmmm... Doesn't that expose a larger problem? The only place the >> ts2020_priv >> struct is allocated is in ts2020_probe() within ts2020.c and the struct >> definition is private to that file and so it can't be allocated from >> outside. >> So if you don't pass through ts2020_probe(), fe->tuner_priv will >> remain NULL >> and the driver will crash. > > Malcolm misses some pending patches where attach() is wrapped to I2C > model probe(). > http://git.linuxtv.org/cgit.cgi/anttip/media_tree.git/log/?h=ts2020 > Hmmm... Yes, I am indeed missing those patches. I will test. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 2/2] ts2020: Provide DVBv5 API signal strength David Howells <dhowells@redhat.com> - 2015-06-03 18:40 +0200
Re: [PATCH 2/2] ts2020: Provide DVBv5 API signal strength Antti Palosaari <crope@iki.fi> - 2015-06-03 18:50 +0200
Re: [PATCH 2/2] ts2020: Provide DVBv5 API signal strength Malcolm Priestley <tvboxspy@gmail.com> - 2015-06-03 19:10 +0200
Re: [PATCH 2/2] ts2020: Provide DVBv5 API signal strength David Howells <dhowells@redhat.com> - 2015-06-03 19:20 +0200
Re: [PATCH 2/2] ts2020: Provide DVBv5 API signal strength Malcolm Priestley <tvboxspy@gmail.com> - 2015-06-03 18:50 +0200
csiph-web