Re: [PATCH 03/11] netfilter: don't use module_init/exit in core IPV4 code

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Pablo Neira Ayuso <pablo@netfilter.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 03/11] netfilter: don't use module_init/exit in core IPV4 code
Date	Wed, 03 Jun 2015 18:00:01 +0200
Message-ID	<pxjfb-5DK-9@gated-at.bofh.it> (permalink)
References	<pwmf7-2fg-3@gated-at.bofh.it> <pwmf8-2fg-15@gated-at.bofh.it>
X-Original-To	Paul Gortmaker <paul.gortmaker@windriver.com>
X-Qmail-Scanner-Diagnostics	from 127.0.0.1 by antivirus5 (envelope-from <pneira@us.es>, uid 501) with qmail-scanner-2.10 (clamdscan: 0.98.7/20550. spamassassin: 3.4.0. Clear:RC:1(127.0.0.1):SA:0(-103.2/7.5):. Processed in 5.102226 secs); 03 Jun 2015 15:59:21 -0000
X-Envelope-From	pneira@us.es
X-Virus-Status	clean(F-Secure/fsigk_smtp/412/antivirus5)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	46
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, Patrick McHardy <kaber@trash.net>, Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>, "David S. Miller" <davem@davemloft.net>, netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
X-Original-Date	Wed, 3 Jun 2015 18:04:29 +0200
X-Original-Message-ID	<20150603160429.GA3565@salvia>
X-Original-References	<1433120052-18281-1-git-send-email-paul.gortmaker@windriver.com> <1433120052-18281-4-git-send-email-paul.gortmaker@windriver.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1157796

Show key headers only | View raw

On Sun, May 31, 2015 at 08:54:04PM -0400, Paul Gortmaker wrote:
> The file net/ipv4/netfilter.o is created based on whether
> CONFIG_NETFILTER is set.  However that is defined as a bool, and
> hence this file with the core netfilter hooks will never be
> modular.  So using module_init as an alias for __initcall can be
> somewhat misleading.
> 
> Fix this up now, so that we can relocate module_init from
> init.h into module.h in the future.  If we don't do this, we'd
> have to add module.h to obviously non-modular code, and that
> would be a worse thing.  Also add an inclusion of init.h, as
> that was previously implicit here in the netfilter.c file.
> 
> Note that direct use of __initcall is discouraged, vs. one
> of the priority categorized subgroups.  As __initcall gets
> mapped onto device_initcall, our use of subsys_initcall (which
> seems to make sense for netfilter code) will thus change this
> registration from level 6-device to level 4-subsys (i.e. slightly
> earlier).  However no observable impact of that small difference
> has been observed during testing, or is expected. (i.e. the
> location of the netfilter messages in dmesg remains unchanged
> with respect to all the other surrounding messages.)
> 
> As for the module_exit, rather than replace it with __exitcall,
> we simply remove it, since it appears only UML does anything
> with those, and even for UML, there is no relevant cleanup
> to be done here.
> 
> Cc: Pablo Neira Ayuso <pablo@netfilter.org>
> Cc: Patrick McHardy <kaber@trash.net>
> Cc: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: netfilter-devel@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>

Or I can integrate this into the nf-next tree if you prefer it.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 03/11] netfilter: don't use module_init/exit in core IPV4  code Pablo Neira Ayuso <pablo@netfilter.org> - 2015-06-03 18:00 +0200
  Re: [PATCH 03/11] netfilter: don't use module_init/exit in core IPV4  code Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-06-03 18:20 +0200

csiph-web