Re: [GIT PULL v4 00/21] libnd: non-volatile memory device support

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Christoph Hellwig <hch@lst.de>
Newsgroups	linux.kernel
Subject	Re: [GIT PULL v4 00/21] libnd: non-volatile memory device support
Date	Wed, 03 Jun 2015 09:00:02 +0200
Message-ID	<pxaOC-1jN-9@gated-at.bofh.it> (permalink)
References	<puRZL-sI-3@gated-at.bofh.it> <pv1Ps-6D3-7@gated-at.bofh.it> <pv7rR-6Hw-35@gated-at.bofh.it>
X-Original-To	Dan Williams <dan.j.williams@intel.com>
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Disposition	inline
Content-Transfer-Encoding	8bit
User-Agent	Mutt/1.5.17 (2007-11-01)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	30
Organization	linux.* mail to news gateway
X-Original-Cc	Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>, Boaz Harrosh <boaz@plexistor.com>, Neil Brown <neilb@suse.de>, Dave Chinner <david@fromorbit.com>, Lv Zheng <lv.zheng@intel.com>, "H. Peter Anvin" <hpa@zytor.com>, Stephen Rothwell <sfr@canb.auug.org.au>, "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>, "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>, Robert Moore <robert.moore@intel.com>, Ingo Molnar <mingo@kernel.org>, Linux ACPI <linux-acpi@vger.kernel.org>, jmoyer <jmoyer@redhat.com>, Nicholas Moulin <nicholas.w.moulin@linux.intel.com>, Matthew Wilcox <willy@linux.intel.com>, Ross Zwisler <ross.zwisler@linux.intel.com>, Vishal Verma <vishal.l.verma@linux.intel.com>, Jens Axboe <axboe@fb.com>, Borislav Petkov <bp@alien8.de>, Thomas Gleixner <tglx@linutronix.de>, Greg KH <gregkh@linuxfoundation.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Andy Lutomirski <luto@amacapital.net>, Andrew Morton <akpm@linux-foundation.org>, Linus Torvalds <torvalds@linux-foundation.org>
X-Original-Date	Wed, 3 Jun 2015 08:55:10 +0200
X-Original-Message-ID	<20150603065510.GB11344@lst.de>
X-Original-References	<20150527210155.17965.74864.stgit@dwillia2-desk3.amr.corp.intel.com> <20150528085124.GA26120@lst.de> <CAPcyv4ieTpdTdH=X9o0+YQ4B+fk9Wp85a55yWKReFAXpdVnSVg@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1157126

Show key headers only | View raw

On Thu, May 28, 2015 at 07:55:47AM -0700, Dan Williams wrote:
> >  - stong NAK for the linker wrapping abuse in the test module
> 
> This capability has been our single largest generator of bug fixes and
> regression prevention.  Please tell me you have a non-bikeshed
> argument why this test approach must die?  We need more tests in tree,
> not less.  That said, it's at the end of the series ready to be lopped
> off like a spent booster rocket if it's really a blocker.

No - you're overloading general functionality to go to something much
slower, with locking implications etc totally invisible to someone reading
the code.  I could be persuaded that a test module makes sense if you
make it an explicit opt-in at the source code level, e.g. a version
of a the pmem driver that needs to be explicitly loaded.

Then again I really don't see the point - if you already need a VM with
ACPI / EFI tables to claim that you have pmem support you might as well
do the pmem emulation in that same virtualіzation environment.

> It makes the identifier prefixes shorter is the bulk of the reasoning
> and a hardware memory resource need not always be a "dimm".  If it's
> just the top-level directory I'm fine with 'nvdimm' or are you looking
> for a rename throughout?

That's the most important part.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [GIT PULL v4 00/21] libnd: non-volatile memory device support Christoph Hellwig <hch@lst.de> - 2015-06-03 09:00 +0200

csiph-web