Re: [PATCH] HID: i2c-hid: Do not set the ACPI companion field in the HID device

From	Mika Westerberg <mika.westerberg@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] HID: i2c-hid: Do not set the ACPI companion field in the HID device
Date	2015-06-03 09:00 +0200
Message-ID	<pxaOB-1jN-5@gated-at.bofh.it> (permalink)
References	<px2o1-5Gh-7@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Tue, Jun 02, 2015 at 02:46:20PM -0700, Andrew Duggan wrote:
> The HID device does not need to know about the ACPI device associated with
> the underlying i2c device. Setting the ACPI companion field in the HID device
> also has the side effect of causing HID to be set as wake capable, since
> acpi_bind_one uses's the companion ACPI device's wakeup flags to set the
> device as wake capable. Which results in power/wakeup files in sysfs for
> the HID device which do not do anything.
> 
> Signed-off-by: Andrew Duggan <aduggan@synaptics.com>

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] HID: i2c-hid: Do not set the ACPI companion field in the  HID device Mika Westerberg <mika.westerberg@linux.intel.com> - 2015-06-03 09:00 +0200

csiph-web