Re: [PATCH v4 0/8] mfd: cros_ec: Add multi EC and proto v3 support

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 0/8] mfd: cros_ec: Add multi EC and proto v3 support
Date	Wed, 03 Jun 2015 08:50:01 +0200
Message-ID	<pxaEV-186-13@gated-at.bofh.it> (permalink)
References	<pwPAt-3Jx-3@gated-at.bofh.it> <px1Ll-4VB-17@gated-at.bofh.it>
X-Original-To	Heiko Stübner <heiko@sntech.de>
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.2.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252
Content-Transfer-Encoding	8bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	59
Organization	linux.* mail to news gateway
X-Original-Cc	Lee Jones <lee.jones@linaro.org>, Samuel Ortiz <sameo@linux.intel.com>, Olof Johansson <olof@lixom.net>, Doug Anderson <dianders@chromium.org>, Bill Richardson <wfrichar@chromium.org>, Simon Glass <sjg@google.com>, Gwendal Grignou <gwendal@google.com>, Stephen Barber <smbarber@chromium.org>, Filipe Brandenburger <filbranden@google.com>, Todd Broch <tbroch@chromium.org>, Alexandru M Stan <amstan@chromium.org>, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
X-Original-Date	Wed, 03 Jun 2015 08:45:32 +0200
X-Original-Message-ID	<556EA28C.2080200@collabora.co.uk>
X-Original-References	<1433232671-27679-1-git-send-email-javier.martinez@collabora.co.uk> <2123062.dmIBPlf795@diego>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1157122

Show key headers only | View raw

Hello Heiko,

On 06/02/2015 11:15 PM, Heiko Stübner wrote:
> Am Dienstag, 2. Juni 2015, 10:11:03 schrieb Javier Martinez Canillas:
>> Hello,
>> 
>> Newer Chromebooks have more than one Embedded Controller (EC) in the
>> system. These additional ECs are connected through I2C with a host EC
>> which is the one that is connected to the Application Processor (AP)
>> through different transports (I2C, SPI or LPC).
>> 
>> So on these platforms, sub-processors are chained to each other:
>> 
>> AP <--> Host EC <--> Power Delivery (PD) EC
>> 
>> The AP sends commands to the additional EC through the host EC using
>> a set of passthru commands and the host redirects to the correct EC.
>> 
>> This is a v4 of a series that adds support for multiple EC in a system
>> and also for the protocol version 3 that is used on newer ECs.
>> 
>> Most patches were taken from the downstream ChromiumOS v3.14 tree with
>> fixes squashed, split to minimise the cross subsystem churn and changes
>> for mainline inclusion but were not modified functionality wise.
>> 
>> This version addresses a lot of issues pointed out by Lee Jones on the v3
>> posted before [0].
>> 
>> The patches are based on top of "[PATCH 0/2] mfd: cros_ec: Small cleanups"
>> [1] that were posted before and was already picked by Lee Jones.
>> 
>> Testing was done on some Chromebooks that have a single EC and support
>> protocol v2 such as the Exynos5250 Snow, Exynos5420 Peach Pit and Exynos5800
>> Peach Pi to be sure that no regressions were introduced for these machines.
> 
> I just gave this a try on veyron and everything still works as expected.
> 
> All patches except "[PATCH v4 6/8] mfd: cros_ec: Support multiple EC in a 
> system" already have Tested-by tags, so this patch now is also
> 
> Tested-by: Heiko Stuebner <heiko@sntech.de>
> 

Thanks a lot for testing the series again.

Now let's wait for Olof to review/ack/provide feedback on patches #1-#6
that touches drivers/platform/chrome, so Lee can merge through his tree.

> 
> Heiko
>

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v4 0/8] mfd: cros_ec: Add multi EC and proto v3 support Javier Martinez Canillas <javier.martinez@collabora.co.uk> - 2015-06-03 08:50 +0200

csiph-web