Re: [PATCH v4 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Heikki Krogerus <heikki.krogerus@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall
Date	Thu, 04 Jun 2015 14:20:02 +0200
Message-ID	<pxChQ-xc-3@gated-at.bofh.it> (permalink)
References	<puyDL-5hI-3@gated-at.bofh.it> <puzq9-6yj-5@gated-at.bofh.it> <puMQq-17H-3@gated-at.bofh.it> <puUkW-3Lf-19@gated-at.bofh.it>
X-Original-To	"Lu, Baolu" <baolu.lu@linux.intel.com>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.13,552,1427785200"; d="scan'208";a="740878661"
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	33
Organization	linux.* mail to news gateway
X-Original-Cc	David Cohen <david.a.cohen@linux.intel.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, balbi@ti.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, qiuxu.zhuo@intel.com
X-Original-Date	Thu, 4 Jun 2015 15:17:00 +0300
X-Original-Message-ID	<20150604121700.GA6283@kuha.fi.intel.com>
X-Original-References	<1432691137-2635-1-git-send-email-baolu.lu@linux.intel.com> <20150527023702.GA7038@kroah.com> <20150527165327.GB1028@psi-dev26.jf.intel.com> <55666644.1060305@linux.intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1158501

Show key headers only | View raw

Hi Baolu,

On Thu, May 28, 2015 at 08:50:12AM +0800, Lu, Baolu wrote:
> On 05/28/2015 12:53 AM, David Cohen wrote:
> >Hi,
> >
> >On Tue, May 26, 2015 at 07:37:02PM -0700, Greg Kroah-Hartman wrote:
> >>On Wed, May 27, 2015 at 09:45:37AM +0800, Lu Baolu wrote:
> >>>Phy drivers and the ulpi interface providers depend on the
> >>>registration of the ulpi bus.  Ulpi registers the bus in
> >>>module_init(). This could cause unnecessary probe delays.
> >>What do you mean by "probe delays"?
> >I believe he meant the bus users' probe delays. i.e. unnecessary
> >-EPROBE_DEFER happening on ulpi_drivers in case they're registered
> >before ulpi bus itself.
> >
> >Is that correct, Baolu?
> 
> Yes.

Could you prepare one more version of this patche with the change log
included.


Thanks,

-- 
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v4 1/1] usb: ulpi: ulpi_init should be executed in  subsys_initcall Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2015-06-04 14:20 +0200

csiph-web