Re: [PATCH] kdbus: use FIELD_SIZEOF in kdbus_member_set_user macro

From	David Herrmann <dh.herrmann@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] kdbus: use FIELD_SIZEOF in kdbus_member_set_user macro
Date	2015-06-04 13:40 +0200
Message-ID	<pxBF8-7YJ-7@gated-at.bofh.it> (permalink)
References	<pxASK-6NR-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi

On Thu, Jun 4, 2015 at 12:39 PM, Sergei Zviagintsev <sergei@s15v.net> wrote:
> sizeof(((_t *)0)->_m) -> FIELD_SIZEOF(_t, _m)
>
> Use conventional macro according to chapter 17 of
> Documentation/CodingStyle.
>
> Signed-off-by: Sergei Zviagintsev <sergei@s15v.net>
> ---
>  ipc/kdbus/util.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: David Herrmann <dh.herrmann@gmail.com>

Thanks
David

> diff --git a/ipc/kdbus/util.h b/ipc/kdbus/util.h
> index 9fedf8ab41cd..529716669fe7 100644
> --- a/ipc/kdbus/util.h
> +++ b/ipc/kdbus/util.h
> @@ -40,7 +40,7 @@
>  ({                                                                     \
>         u64 __user *_sz =                                               \
>                 (void __user *)((u8 __user *)(_b) + offsetof(_t, _m));  \
> -       copy_to_user(_sz, _s, sizeof(((_t *)0)->_m));                   \
> +       copy_to_user(_sz, _s, FIELD_SIZEOF(_t, _m));                    \
>  })
>
>  /**
> --
> 1.8.3.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] kdbus: use FIELD_SIZEOF in kdbus_member_set_user macro Sergei Zviagintsev <sergei@s15v.net> - 2015-06-04 12:50 +0200
  Re: [PATCH] kdbus: use FIELD_SIZEOF in kdbus_member_set_user macro David Herrmann <dh.herrmann@gmail.com> - 2015-06-04 13:40 +0200

csiph-web