Re: of/dynamic: Fix test for PPC_PSERIES

From	Michael Ellerman <mpe@ellerman.id.au>
Newsgroups	linux.kernel
Subject	Re: of/dynamic: Fix test for PPC_PSERIES
Date	2015-06-04 13:00 +0200
Message-ID	<pxB2q-6YZ-15@gated-at.bofh.it> (permalink)
References	<pxzN0-53p-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 2015-04-06 at 09:34:41 UTC, Geert Uytterhoeven wrote:
> "IS_ENABLED(PPC_PSERIES)" always evaluates to false, as IS_ENABLED() is
> supposed to be used with the full Kconfig symbol name, including the
> "CONFIG_" prefix.
> 
> Add the missing "CONFIG_" prefix to fix this.
> 
> Fixes: a25095d451ece23b ("of: Move dynamic node fixups out of powerpc and into common code")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---

> Did this bug cause any breakage?
> If yes, the fix should go to stable (for v3.17 and later).

Yikes. Not that I've heard of. But it's reasonably new so possibly it's not hit
distros that folks tend to run on those machines.

I'm also not clear how it would break, it could be subtle and we've not noticed.

Nathan might have more of an idea (on CC).

On my machine here everything that has an ibm,phandle also has a linux,phandle,
so we wouldn't hit that code path. But I'm not sure how representative that box
is.

cheers
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: of/dynamic: Fix test for PPC_PSERIES Michael Ellerman <mpe@ellerman.id.au> - 2015-06-04 13:00 +0200
  Re: of/dynamic: Fix test for PPC_PSERIES Nathan Fontenot <nfont@linux.vnet.ibm.com> - 2015-06-05 02:50 +0200

csiph-web