Re: Fwd: [RFC] make kthread_worker_fn to be freezable

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: Fwd: [RFC] make kthread_worker_fn to be freezable
Date	2015-06-03 07:30 +0200
Message-ID	<px9pw-7O6-5@gated-at.bofh.it> (permalink)
References	<pwuPo-6HJ-23@gated-at.bofh.it> <pwuPo-6HJ-21@gated-at.bofh.it> <pwwoa-nd-1@gated-at.bofh.it> <pwKU9-5ez-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jun 02, 2015 at 11:13:44AM +0800, yalin wang wrote:
> this means i need create kthread like this :
> 
> struct task_struct *kworker_task = kthread_run(kthread_worker_fn,
> &worker, "nvme%d", dev->instance);
> kworker_task->flags &= ~PF_NOFREEZE;
> is it safe to do like this ?

It's not.

> i don't see an API to set other thread to be freezable .
> only set_freezable() , which set the current thread to be freezable .

But you can create a wrapper kthread function which sets freezable and
calls kthread_worker_fn().

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: Fwd: [RFC] make kthread_worker_fn to be freezable Tejun Heo <tj@kernel.org> - 2015-06-03 07:30 +0200

csiph-web