Re: [Patch v3 27/36] x86, irq: Use access helper irq_data_get_affinity_mask()

From	Jiang Liu <jiang.liu@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [Patch v3 27/36] x86, irq: Use access helper irq_data_get_affinity_mask()
Date	2015-06-03 04:00 +0200
Message-ID	<px68i-2Kb-1@gated-at.bofh.it> (permalink)
References	<pwsXg-3Xw-3@gated-at.bofh.it> <pwsXh-3Xw-17@gated-at.bofh.it> <px02S-2mG-31@gated-at.bofh.it>
Organization	Intel

Show all headers | View raw

On 2015/6/3 3:19, Thomas Gleixner wrote:
> On Mon, 1 Jun 2015, Jiang Liu wrote:
> 
>> diff --git a/arch/x86/kernel/apic/vector.c b/arch/x86/kernel/apic/vector.c
>> index 9b62f690b0ff..dfa3a5f5b3d3 100644
>> --- a/arch/x86/kernel/apic/vector.c
>> +++ b/arch/x86/kernel/apic/vector.c
>> @@ -494,9 +494,8 @@ static int apic_set_affinity(struct irq_data *irq_data,
>>  
>>  	err = assign_irq_vector(irq, data, dest);
>>  	if (err) {
>> -		struct irq_data *top = irq_get_irq_data(irq);
>> -
>> -		if (assign_irq_vector(irq, data, top->affinity))
>> +		if (assign_irq_vector(irq, data,
>> +				      irq_data_get_affinity_mask(irq_data)))
> 
> Does this patch work w/o moving the affinity mask to common data? I
> doubt so, as you remove the retrieval of 'top'.
Hi Thomas,
	This piece of code should be moved into [31/36], otherwise
it will break bisecting. I will redo patch this and [31/36] to
support bisecting.
Thanks!
Gerry

> 
> Thanks,
> 
> 	tglx
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [Patch v3 27/36] x86, irq: Use access helper irq_data_get_affinity_mask() Jiang Liu <jiang.liu@linux.intel.com> - 2015-06-03 04:00 +0200

csiph-web