Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1210521
| From | Alan Stern <stern@rowland.harvard.edu> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | RE: [PATCH 3/8][v3]usb:fsl:otg: Add support to add/remove usb host driver |
| Date | 2015-08-20 16:20 +0200 |
| Message-ID | <pZyRc-7lc-17@gated-at.bofh.it> (permalink) |
| References | <pZqJY-3Q7-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, 20 Aug 2015, Ramneek Mehresh wrote:
> > > --- a/drivers/usb/host/ehci-fsl.h
> > > +++ b/drivers/usb/host/ehci-fsl.h
> > > @@ -63,4 +63,22 @@
> > > #define UTMI_PHY_EN (1<<9)
> > > #define ULPI_PHY_CLK_SEL (1<<10)
> > > #define PHY_CLK_VALID (1<<17)
> > > +
> > > +struct ehci_fsl {
> > > +#ifdef CONFIG_PM
> > > + /* Saved USB PHY settings, need to restore after deep sleep. */
> > > + u32 usb_ctrl;
> > > +#endif
> >
> > Do you need this #ifdef?
> >
> Yes, this is required for deep-sleep support...we need to save/restore controller
> registers during deep-sleep when usb controller power is shut-off. Don't need this
> during normal usb operation...saving/restoring usb controller registers in non deep-sleep
> scenario will add unnecessary delays
What I meant was, can you keep the "u32 usb_ctrl;" line but get rid of
the "#ifdef CONFIG_PM" and "#endif" lines?
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
RE: [PATCH 3/8][v3]usb:fsl:otg: Add support to add/remove usb host driver Ramneek Mehresh <ramneek.mehresh@freescale.com> - 2015-08-20 07:40 +0200
RE: [PATCH 3/8][v3]usb:fsl:otg: Add support to add/remove usb host driver Alan Stern <stern@rowland.harvard.edu> - 2015-08-20 16:20 +0200
RE: [PATCH 3/8][v3]usb:fsl:otg: Add support to add/remove usb host driver Ramneek Mehresh <ramneek.mehresh@freescale.com> - 2015-08-24 08:20 +0200
RE: [PATCH 3/8][v3]usb:fsl:otg: Add support to add/remove usb host driver Alan Stern <stern@rowland.harvard.edu> - 2015-08-24 16:40 +0200
csiph-web