Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1210412

RE: [PATCH] usb: gadget: f_uac1: Convert use of __constant_cpu_to_le16 to cpu_to_le16

Show all headers | View raw

From: Vaishali Thakkar
> Sent: 19 August 2015 06:31
> To: Felipe Balbi
> Cc: Greg Kroah-Hartman; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] usb: gadget: f_uac1: Convert use of __constant_cpu_to_le16 to cpu_to_le16
> 
> In big endian cases, macro cpu_to_le16 unfolds to __swab16 which
> provides special case for constants. In little endian cases,
> __constant_cpu_to_le16 and cpu_to_le16 expand directly to the
> same expression. So, replace __constant_cpu_to_le16 with
> cpu_to_le16 with the goal of getting rid of the definition of
> __constant_cpu_to_le16 completely.
> 
> The semantic patch that performs this transformation is as follows:
> 
> @@expression x;@@
> 
> - __constant_cpu_to_le16(x)
> + cpu_to_le16(x)
> 
> Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
> ---
>  drivers/usb/gadget/function/f_uac1.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/gadget/function/f_uac1.c b/drivers/usb/gadget/function/f_uac1.c
> index 7856b33..5aa8d8a 100644
> --- a/drivers/usb/gadget/function/f_uac1.c
> +++ b/drivers/usb/gadget/function/f_uac1.c
> @@ -57,8 +57,8 @@ static struct uac1_ac_header_descriptor_1 ac_header_desc = {
>  	.bLength =		UAC_DT_AC_HEADER_LENGTH,
>  	.bDescriptorType =	USB_DT_CS_INTERFACE,
>  	.bDescriptorSubtype =	UAC_HEADER,
> -	.bcdADC =		__constant_cpu_to_le16(0x0100),
> -	.wTotalLength =		__constant_cpu_to_le16(UAC_DT_TOTAL_LENGTH),
> +	.bcdADC =		cpu_to_le16(0x0100),
> +	.wTotalLength =		cpu_to_le16(UAC_DT_TOTAL_LENGTH),

Have you test compiled this on a big-endian system?
My gut feeling is that is fails.

	David

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] usb: gadget: f_uac1: Convert use of __constant_cpu_to_le16  to cpu_to_le16 Vaishali Thakkar <vthakkar1994@gmail.com> - 2015-08-19 07:40 +0200
  RE: [PATCH] usb: gadget: f_uac1: Convert use of  __constant_cpu_to_le16 to cpu_to_le16 David Laight <David.Laight@ACULAB.COM> - 2015-08-20 13:00 +0200
    Re: [PATCH] usb: gadget: f_uac1: Convert use of __constant_cpu_to_le16  to cpu_to_le16 Vaishali Thakkar <vthakkar1994@gmail.com> - 2015-08-22 04:00 +0200
      RE: [PATCH] usb: gadget: f_uac1: Convert use of  __constant_cpu_to_le16 to cpu_to_le16 David Laight <David.Laight@ACULAB.COM> - 2015-08-24 11:10 +0200
        Re: [PATCH] usb: gadget: f_uac1: Convert use of __constant_cpu_to_le16  to cpu_to_le16 Vaishali Thakkar <vthakkar1994@gmail.com> - 2015-08-24 12:50 +0200

csiph-web