Re: [PATCH v1 2/4] dmaengine: xgene-dma: Add support for CRC32C calculation via DMA engine

From	Vinod Koul <vinod.koul@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1 2/4] dmaengine: xgene-dma: Add support for CRC32C calculation via DMA engine
Date	2015-08-20 09:20 +0200
Message-ID	<pZsiK-6gT-13@gated-at.bofh.it> (permalink)
References	<pRUYx-6sC-9@gated-at.bofh.it> <pRUYy-6sC-15@gated-at.bofh.it> <pZqJY-3Q7-3@gated-at.bofh.it> <pZrZo-5EL-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Aug 20, 2015 at 12:23:50PM +0530, Rameshwar Sahu wrote:
> Hi Vinod,
> 
> On Thu, Aug 20, 2015 at 11:10 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> > On Thu, Jul 30, 2015 at 05:41:06PM +0530, Rameshwar Prasad Sahu wrote:
> >> +     /* Invalidate unused source address field */
> >> +     for (; i < 4; i++)
> >> +             xgene_dma_invalidate_buffer(xgene_dma_lookup_ext8(desc2, i));
> >> +
> >> +     /* Check whether requested buffer processed */
> >> +     if (nbytes) {
> >> +             chan_err(chan, "Src count crossed maximum limit\n");
> >> +             return -EINVAL;
> > no cleanup ?
> Here not required, cleanup I am doing in parent function from where
> this function is getting called in case of failure.
> >
> >> +struct dma_async_tx_descriptor *xgene_dma_prep_flyby(
> >> +     struct xgene_dma_chan *chan, struct scatterlist *src_sg,
> >> +     size_t len, u32 seed, u8 *result, unsigned long flags, u8 opcode)
> > please fix style here
> 
> Could you explain me What kind of coding style you would like here ??

See CodingStyle Chapter 2

-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v1 2/4] dmaengine: xgene-dma: Add support for CRC32C  calculation via DMA engine Vinod Koul <vinod.koul@intel.com> - 2015-08-20 07:40 +0200
  Re: [PATCH v1 2/4] dmaengine: xgene-dma: Add support for CRC32C  calculation via DMA engine Rameshwar Sahu <rsahu@apm.com> - 2015-08-20 09:00 +0200
    Re: [PATCH v1 2/4] dmaengine: xgene-dma: Add support for CRC32C  calculation via DMA engine Vinod Koul <vinod.koul@intel.com> - 2015-08-20 09:20 +0200

csiph-web