Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1210241

Re: [PATCH v3 13/14] drm: bridge/analogix_dp: move hpd detect to connector detect function

From Jingoo Han <jingoohan1@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH v3 13/14] drm: bridge/analogix_dp: move hpd detect to connector detect function
Date 2015-08-20 09:50 +0200
Message-ID <pZsLL-6P8-11@gated-at.bofh.it> (permalink)
References <pZcQF-qk-19@gated-at.bofh.it> <pZd0n-BY-31@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 2015. 8. 19., at PM 11:52, Yakir Yang <ykk@rock-chips.com> wrote:
> 


What is the reason to make this patch?

Please make commit message including the reason.

Best regards,
Jingoo Han

> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> ---
> Changes in v3:
> - move dp hpd detect to connector detect function.
> 
> Changes in v2: None
> 
> drivers/gpu/drm/bridge/analogix_dp_core.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix_dp_core.c
> index 75dd44a..052b9b3 100644
> --- a/drivers/gpu/drm/bridge/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix_dp_core.c
> @@ -915,12 +915,6 @@ static void analogix_dp_commit(struct analogix_dp_device *dp)
>            DRM_ERROR("failed to disable the panel\n");
>    }
> 
> -    ret = analogix_dp_detect_hpd(dp);
> -    if (ret) {
> -        /* Cable has been disconnected, we're done */
> -        return;
> -    }
> -
>    ret = analogix_dp_handle_edid(dp);
>    if (ret) {
>        dev_err(dp->dev, "unable to handle edid\n");
> @@ -953,6 +947,12 @@ static void analogix_dp_commit(struct analogix_dp_device *dp)
> static enum drm_connector_status analogix_dp_detect(
>                struct drm_connector *connector, bool force)
> {
> +    struct analogix_dp_device *dp = connector_to_dp(connector);
> +
> +    if (analogix_dp_detect_hpd(dp))
> +        /* Cable has been disconnected, we're done */
> +        return connector_status_disconnected;
> +
>    return connector_status_connected;
> }
> 
> -- 
> 1.9.1
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v3 0/14] Add Analogix Core Display Port Driver Yakir Yang <ykk@rock-chips.com> - 2015-08-19 16:50 +0200
  [PATCH v3 07/14] drm: rockchip/dp: add rockchip platform dp driver Yakir Yang <ykk@rock-chips.com> - 2015-08-19 17:00 +0200
  [PATCH v3 06/14] Documentation: drm/bridge: add document for analogix_dp Yakir Yang <ykk@rock-chips.com> - 2015-08-19 17:00 +0200
    Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for analogix_dp Rob Herring <robherring2@gmail.com> - 2015-08-24 01:30 +0200
      Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for analogix_dp Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-08-24 02:50 +0200
        Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for  analogix_dp Yakir Yang <ykk@rock-chips.com> - 2015-08-24 04:50 +0200
          Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for  analogix_dp Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-08-24 06:30 +0200
            Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for  analogix_dp Yakir Yang <ykk@rock-chips.com> - 2015-08-24 14:50 +0200
              Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for analogix_dp Heiko Stuebner <heiko@sntech.de> - 2015-08-24 15:10 +0200
                Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for  analogix_dp Yakir Yang <ykk@rock-chips.com> - 2015-08-25 03:40 +0200
              Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for  analogix_dp Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-08-25 02:00 +0200
                Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for  analogix_dp Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-08-25 03:40 +0200
                Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for  analogix_dp Yakir Yang <ykk@rock-chips.com> - 2015-08-25 03:40 +0200
        Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for analogix_dp Jingoo Han <jingoohan1@gmail.com> - 2015-08-24 09:50 +0200
          Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for  analogix_dp Yakir Yang <ykk@rock-chips.com> - 2015-08-24 15:00 +0200
      Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for  analogix_dp Yakir Yang <ykk@rock-chips.com> - 2015-08-24 04:30 +0200
      Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for  analogix_dp Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-08-24 15:00 +0200
        Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for analogix_dp Rob Herring <robherring2@gmail.com> - 2015-08-24 16:50 +0200
          Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for analogix_dp Heiko Stuebner <heiko@sntech.de> - 2015-08-24 18:20 +0200
          Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for  analogix_dp Yakir Yang <ykk@rock-chips.com> - 2015-08-25 03:30 +0200
          Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for  analogix_dp Thierry Reding <treding@nvidia.com> - 2015-08-25 11:20 +0200
            Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for  analogix_dp Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-08-25 11:40 +0200
              Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for  analogix_dp Thierry Reding <treding@nvidia.com> - 2015-08-25 12:50 +0200
                Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for  analogix_dp Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-08-25 13:00 +0200
            Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for  analogix_dp Yakir Yang <ykk@rock-chips.com> - 2015-08-25 11:50 +0200
              Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for  analogix_dp Thierry Reding <treding@nvidia.com> - 2015-08-25 12:10 +0200
                Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for  analogix_dp Yakir Yang <ykk@rock-chips.com> - 2015-08-25 16:10 +0200
      Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for  analogix_dp Thierry Reding <treding@nvidia.com> - 2015-08-25 11:20 +0200
        Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for  analogix_dp Yakir Yang <ykk@rock-chips.com> - 2015-08-25 11:40 +0200
        Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for analogix_dp Rob Herring <robherring2@gmail.com> - 2015-08-25 15:30 +0200
          Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for  analogix_dp Thierry Reding <treding@nvidia.com> - 2015-08-25 16:20 +0200
            Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for  analogix_dp Yakir Yang <ykk@rock-chips.com> - 2015-08-25 16:30 +0200
    Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for  analogix_dp Thierry Reding <treding@nvidia.com> - 2015-08-25 12:00 +0200
      Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for  analogix_dp Yakir Yang <ykk@rock-chips.com> - 2015-08-25 16:10 +0200
        Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for  analogix_dp Thierry Reding <treding@nvidia.com> - 2015-08-25 16:30 +0200
          Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for  analogix_dp Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-08-25 18:00 +0200
  [PATCH v3 14/14] drm: bridge/analogix_dp: add edid modes parse in get_modes method Yakir Yang <ykk@rock-chips.com> - 2015-08-19 17:00 +0200
  [PATCH v3 08/14] phy: Add driver for rockchip Display Port PHY Yakir Yang <ykk@rock-chips.com> - 2015-08-19 17:00 +0200
    Re: [PATCH v3 08/14] phy: Add driver for rockchip Display Port PHY Kishon Vijay Abraham I <kishon@ti.com> - 2015-08-20 06:50 +0200
  [PATCH v3 11/14] drm: bridge: analogix_dp: try force hpd after plug in lookup failed Yakir Yang <ykk@rock-chips.com> - 2015-08-19 17:00 +0200
  [PATCH v3 05/14] drm: bridge/analogix_dp: fix link_rate & lane_count bug Yakir Yang <ykk@rock-chips.com> - 2015-08-19 17:00 +0200
    Re: [PATCH v3 05/14] drm: bridge/analogix_dp: fix link_rate & lane_count bug Jingoo Han <jingoohan1@gmail.com> - 2015-08-20 09:30 +0200
      Re: [PATCH v3 05/14] drm: bridge/analogix_dp: fix link_rate & lane_count  bug Yakir Yang <ykk@rock-chips.com> - 2015-08-20 10:10 +0200
  [PATCH v3 12/14] drm: bridge/analogix_dp: expand the delay time for hpd detect Yakir Yang <ykk@rock-chips.com> - 2015-08-19 17:00 +0200
    Re: [PATCH v3 12/14] drm: bridge/analogix_dp: expand the delay time for hpd detect Jingoo Han <jingoohan1@gmail.com> - 2015-08-20 08:20 +0200
      Re: [PATCH v3 12/14] drm: bridge/analogix_dp: expand the delay time  for hpd detect Yakir Yang <ykk@rock-chips.com> - 2015-08-20 10:10 +0200
  [PATCH v3 04/14] drm: bridge/analogix_dp: dynamic parse sync_pol & interlace & colorimetry Yakir Yang <ykk@rock-chips.com> - 2015-08-19 17:00 +0200
  [PATCH v3 02/14] drm: exynos/dp: convert to drm bridge mode Yakir Yang <ykk@rock-chips.com> - 2015-08-19 17:00 +0200
  [PATCH v3 13/14] drm: bridge/analogix_dp: move hpd detect to connector detect function Yakir Yang <ykk@rock-chips.com> - 2015-08-19 17:00 +0200
    Re: [PATCH v3 13/14] drm: bridge/analogix_dp: move hpd detect to connector detect function Jingoo Han <jingoohan1@gmail.com> - 2015-08-20 09:50 +0200
      Re: [PATCH v3 13/14] drm: bridge/analogix_dp: move hpd detect to  connector detect function Yakir Yang <ykk@rock-chips.com> - 2015-08-20 10:20 +0200
  [PATCH v3 10/14] drm: bridge: analogix_dp: add some rk3288 special registers setting Yakir Yang <ykk@rock-chips.com> - 2015-08-19 17:00 +0200
  [PATCH v3 09/14] drm: bridge/analogix_dp: add platform device type support Yakir Yang <ykk@rock-chips.com> - 2015-08-19 17:00 +0200
  [PATCH v3 01/14] drm: exynos/dp: fix code style Yakir Yang <ykk@rock-chips.com> - 2015-08-19 17:00 +0200
  Re: [PATCH v3 0/14] Add Analogix Core Display Port Driver Dave Airlie <airlied@gmail.com> - 2015-08-20 02:00 +0200
    Re: [PATCH v3 0/14] Add Analogix Core Display Port Driver Yakir Yang <ykk@rock-chips.com> - 2015-08-20 03:10 +0200
  Re: [PATCH v3 0/14] Add Analogix Core Display Port Driver Archit Taneja <architt@codeaurora.org> - 2015-08-20 06:40 +0200
    Re: [PATCH v3 0/14] Add Analogix Core Display Port Driver Jingoo Han <jingoohan1@gmail.com> - 2015-08-20 08:00 +0200
      Re: [PATCH v3 0/14] Add Analogix Core Display Port Driver Yakir Yang <ykk@rock-chips.com> - 2015-08-20 08:30 +0200
        Re: [PATCH v3 0/14] Add Analogix Core Display Port Driver Jingoo Han <jingoohan1@gmail.com> - 2015-08-20 09:00 +0200
          Re: [PATCH v3 0/14] Add Analogix Core Display Port Driver Yakir Yang <ykk@rock-chips.com> - 2015-08-20 10:10 +0200
  Re: [PATCH v3 0/14] Add Analogix Core Display Port Driver Jingoo Han <jingoohan1@gmail.com> - 2015-08-21 10:30 +0200
    Re: [PATCH v3 0/14] Add Analogix Core Display Port Driver Thierry Reding <treding@nvidia.com> - 2015-08-21 15:20 +0200
      Re: [PATCH v3 0/14] Add Analogix Core Display Port Driver Romain Perier <romain.perier@gmail.com> - 2015-08-30 14:20 +0200
        Re: [PATCH v3 0/14] Add Analogix Core Display Port Driver Yakir Yang <ykk@rock-chips.com> - 2015-08-31 04:50 +0200

csiph-web