Re: [PATCH 5/5] drivers/tty: make serial 8250_lpc18xx.c Kconfig a tristate

From	Joachim Eastwood <manabian@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/5] drivers/tty: make serial 8250_lpc18xx.c Kconfig a tristate
Date	2015-08-20 09:00 +0200
Message-ID	<pZrZn-5EL-11@gated-at.bofh.it> (permalink)
References	<pZjp8-1sc-3@gated-at.bofh.it> <pZjyP-1GO-45@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 19 August 2015 at 23:48, Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
> The Kconfig currently controlling compilation of this code is:
>
> 8250/Kconfig:config SERIAL_8250_LPC18XX
> 8250/Kconfig:        bool "NXP LPC18xx/43xx serial port support"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> When targetting orphaned modular code in non-modular drivers, this
> came up.  Joachim indicated that the driver was actually meant to
> be tristate but ended up bool by accident.  So here we make it
> tristate instead of removing the modular code that was essentially
> orphaned.
>
> Suggested-by: Joachim Eastwood <manabian@gmail.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jslaby@suse.com>
> Cc: Joachim Eastwood <manabian@gmail.com>
> Cc: linux-serial@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Acked-by: Joachim Eastwood <manabian@gmail.com>

Build tested as a module on lpc18xx.

Thanks for fixing it Paul.


regards,
Joachim Eastwood
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/5] drivers/tty: make more bool drivers explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-08-20 00:00 +0200
  [PATCH 5/5] drivers/tty: make serial 8250_lpc18xx.c Kconfig a tristate Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-08-20 00:00 +0200
    Re: [PATCH 5/5] drivers/tty: make serial 8250_lpc18xx.c Kconfig a tristate Joachim Eastwood <manabian@gmail.com> - 2015-08-20 09:00 +0200

csiph-web