Re: [PATCH 1/2] ubifs: Remove dead xattr code

From	Richard Weinberger <richard@nod.at>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] ubifs: Remove dead xattr code
Date	2015-08-20 08:50 +0200
Message-ID	<pZrPI-5tD-7@gated-at.bofh.it> (permalink)
References	<pZijn-8mM-15@gated-at.bofh.it> <pZof8-8up-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Am 20.08.2015 um 04:48 schrieb Dongsheng Yang:
> On 08/20/2015 04:35 AM, Richard Weinberger wrote:
>> This is a partial revert of commit d7f0b70d30ffb9bbe6b8a3e1035cf0b79965ef53
>> ("UBIFS: Add security.* XATTR support for the UBIFS").
> 
> Hi Richard,
>     What about a full reverting of this commit. In ubifs, we
> *can* support any namespace of xattr including user, trusted, security
> or other anyone prefixed by any words. But we have a check_namespace()
> in xattr.c to limit what we want to support. That said, if we want to
> "Add security.* XATTR support for the UBIFS", what we need to do is
> just extending the check_namespace() to allow security namespace pass.
> And yes, check_namespace() have been supporting security namespace.

You're right. I thought/hoped we can re-use some parts of it.
Se let's do a full revert. I'll send a v2 patch in a jiffy.

> So, IMHO, we do not depend on the generic mechanism at all, and we can
> fully revert this commit.
> 
> But strange to me, why we picked this commit for ubifs? Artem, is there
> something I am missing?

TBH, I fear nobody noticed. :(

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 1/2] ubifs: Remove dead xattr code Richard Weinberger <richard@nod.at> - 2015-08-19 22:40 +0200
  Re: [PATCH 1/2] ubifs: Remove dead xattr code Dongsheng Yang <yangds.fnst@cn.fujitsu.com> - 2015-08-20 05:00 +0200
    Re: [PATCH 1/2] ubifs: Remove dead xattr code Richard Weinberger <richard@nod.at> - 2015-08-20 08:50 +0200
    Re: [PATCH 1/2] ubifs: Remove dead xattr code Artem Bityutskiy <artem.bityutskiy@linux.intel.com> - 2015-08-20 08:50 +0200
    Re: [PATCH 1/2] ubifs: Remove dead xattr code Josh Cartwright <joshc@ni.com> - 2015-08-26 16:20 +0200
      Re: [PATCH 1/2] ubifs: Remove dead xattr code Dongsheng Yang <yangds.fnst@cn.fujitsu.com> - 2015-08-27 03:10 +0200

csiph-web