Re: [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page()

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Julien Grall <julien.grall@citrix.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page()
Date	Thu, 20 Aug 2015 02:30:02 +0200
Message-ID	<pZlTY-5bn-5@gated-at.bofh.it> (permalink)
References	<pZbBg-7a5-15@gated-at.bofh.it>
X-Original-To	Murilo Opsfelder Araujo <mopsfelder@gmail.com>, <linux-kernel@vger.kernel.org>, <xen-devel@lists.xenproject.org>
X-Ironport-Av	E=Sophos;i="5.15,713,1432598400"; d="scan'208";a="296131491"
User-Agent	Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version	1.0
Content-Type	text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding	8bit
X-Dlp	MIA2
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	33
Organization	linux.* mail to news gateway
X-Original-Cc	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, David Vrabel <david.vrabel@citrix.com>
X-Original-Date	Wed, 19 Aug 2015 17:23:55 -0700
X-Original-Message-ID	<55D51E1B.8090701@citrix.com>
X-Original-References	<1439990719-19517-1-git-send-email-mopsfelder@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1210095

Show key headers only | View raw

Hi,

On 19/08/2015 06:25, Murilo Opsfelder Araujo wrote:
> The commit 091208a676dfdabb2b8fe86ee155c6fc80081b69 "xen/tmem: Use
> xen_page_to_gfn rather than pfn_to_gfn" left behind a call to
> xen_tmem_get_page() receiving pfn instead of page.
>
> This change also fixes the following build warning:
>
> drivers/xen/tmem.c: In function ‘tmem_cleancache_get_page’:
> drivers/xen/tmem.c:194:47: warning: passing argument 4 of ‘xen_tmem_get_page’ makes pointer from integer without a cast
>    ret = xen_tmem_get_page((u32)pool, oid, ind, pfn);
>                                                 ^
> drivers/xen/tmem.c:138:12: note: expected ‘struct page *’ but argument is of type ‘long unsigned int’
>   static int xen_tmem_get_page(u32 pool_id, struct tmem_oid oid,
>              ^
>
> Signed-off-by: Murilo Opsfelder Araujo <mopsfelder@gmail.com>

Sorry for the breakage, I haven't spot it because CONFIG_CLEANCACHE is 
not enabled on my config.

Reviewed-by: Julien Grall <julien.grall@citrix.com>

Regards,

-- 
Julien Grall
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page() Murilo Opsfelder Araujo <mopsfelder@gmail.com> - 2015-08-19 15:30 +0200
  Re: [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page() Julien Grall <julien.grall@citrix.com> - 2015-08-20 02:30 +0200
    Re: [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page() Murilo Opsfelder Araújo <mopsfelder@gmail.com> - 2015-08-22 17:00 +0200
  Re: [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page() David Vrabel <david.vrabel@citrix.com> - 2015-08-20 13:30 +0200
    Re: [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page() Murilo Opsfelder Araújo <mopsfelder@gmail.com> - 2015-08-22 17:00 +0200

csiph-web