Re: [PATCH] irqchip: gic-v3: Explicitly include linux/io.h

From	Ben Zhang <benzh@google.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] irqchip: gic-v3: Explicitly include linux/io.h
Date	2015-08-20 00:50 +0200
Message-ID	<pZklc-2RT-23@gated-at.bofh.it> (permalink)
References	<pUIxP-6MV-3@gated-at.bofh.it> <pULvH-2KM-9@gated-at.bofh.it> <pUZp0-6k4-7@gated-at.bofh.it> <pZiW7-U7-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

This patch is not really needed. The build failure on our v3.18-based
kernel is fixed by cherry-picking commit 332fd7c4fef5 ("genirq:
Generic chip: Change irq_reg_{readl,writel} arguments") which is
actually a functional no-op. This patch could help prevent future
build failure in case linux/io.h is later removed from linux/irq.h.
Since the irq-gic-v3 driver uses the read/write io functions, it might
be better to include linux/io.h explicitly.

Thanks,
Ben

On Wed, Aug 19, 2015 at 2:13 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Fri, 7 Aug 2015, Ben Zhang wrote:
>> Mainline build is fine because commit 332fd7c4fef5("genirq: Generic
>> chip: Change irq_reg_{readl,writel} arguments") landed before the
>> timecounter patch, and it creates a new include path to the io.h
>> header:
>> arch/arm64/include/asm/io.h
>> include/linux/io.h
>> include/linux/irq.h
>> include/linux/of_irq.h
>> drivers/irqchip/irq-gic-v3.c
>
> And why do we need to include it once more then?
>
> Thanks,
>
>         tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] irqchip: gic-v3: Explicitly include linux/io.h Ben Zhang <benzh@chromium.org> - 2015-08-07 07:40 +0200
  Re: [PATCH] irqchip: gic-v3: Explicitly include linux/io.h Marc Zyngier <marc.zyngier@arm.com> - 2015-08-07 10:50 +0200
    Re: [PATCH] irqchip: gic-v3: Explicitly include linux/io.h Ben Zhang <benzh@chromium.org> - 2015-08-08 01:40 +0200
      Re: [PATCH] irqchip: gic-v3: Explicitly include linux/io.h Thomas Gleixner <tglx@linutronix.de> - 2015-08-19 23:20 +0200
        Re: [PATCH] irqchip: gic-v3: Explicitly include linux/io.h Ben Zhang <benzh@google.com> - 2015-08-20 00:50 +0200

csiph-web