Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1209944

Re: [PATCH v4 1/3] ARM: qcom: add SFPB nodes to IPQ806x dts

Show all headers | View raw

On Tue 18 Aug 14:04 PDT 2015, Mathieu Olivari wrote:

> Add one new node to the ipq806x.dtsi file to declare & register the
> hardware spinlock devices. This mechanism is required to be used by
> other drivers such as SMEM.
> 

Still looks good, but you should have added:

Reviewed-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> Signed-off-by: Mathieu Olivari <mathieu@codeaurora.org>
> ---
>  arch/arm/boot/dts/qcom-ipq8064.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> index 9f727d8..8d366ae 100644
> --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> @@ -329,5 +329,16 @@
>  			#reset-cells = <1>;
>  		};
>  
> +		sfpb_mutex_block: syscon@1200600 {
> +			compatible = "syscon";
> +			reg = <0x01200600 0x100>;
> +		};
> +	};
> +
> +	sfpb_mutex: sfpb-mutex {
> +		compatible = "qcom,sfpb-mutex";
> +		syscon = <&sfpb_mutex_block 4 4>;
> +
> +		#hwlock-cells = <1>;
>  	};
>  };
> -- 
> 2.1.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/3] qcom: Add SMEM MTD parser Mathieu Olivari <mathieu@codeaurora.org> - 2015-08-18 23:10 +0200
  [PATCH v4 2/3] ARM: qcom: add SMEM device node to IPQ806x dts Mathieu Olivari <mathieu@codeaurora.org> - 2015-08-18 23:10 +0200
    Re: [PATCH v4 2/3] ARM: qcom: add SMEM device node to IPQ806x dts Bjorn Andersson <bjorn.andersson@sonymobile.com> - 2015-08-19 18:40 +0200
    Re: [PATCH v4 2/3] ARM: qcom: add SMEM device node to IPQ806x dts Stephen Boyd <sboyd@codeaurora.org> - 2015-08-25 02:30 +0200
  [PATCH v4 1/3] ARM: qcom: add SFPB nodes to IPQ806x dts Mathieu Olivari <mathieu@codeaurora.org> - 2015-08-18 23:10 +0200
    Re: [PATCH v4 1/3] ARM: qcom: add SFPB nodes to IPQ806x dts Bjorn Andersson <bjorn.andersson@sonymobile.com> - 2015-08-19 18:40 +0200
    Re: [PATCH v4 1/3] ARM: qcom: add SFPB nodes to IPQ806x dts Stephen Boyd <sboyd@codeaurora.org> - 2015-08-25 02:30 +0200
  [PATCH v4 3/3] mtd: add SMEM parser for QCOM platforms Mathieu Olivari <mathieu@codeaurora.org> - 2015-08-18 23:10 +0200
    Re: [PATCH v4 3/3] mtd: add SMEM parser for QCOM platforms Bjorn Andersson <bjorn.andersson@sonymobile.com> - 2015-08-19 18:40 +0200

csiph-web