Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1209930

Re: [PATCH] regulator: qcom_smd: Set n_voltages for pm8941_lnldo

Show all headers | View raw

On Tue 18 Aug 20:17 PDT 2015, Axel Lin wrote:

> Just setting fixed_uV is not enough, the regulator core will also check
> n_voltages setting. The fixed_uV only works when n_voltages is 1.
> 

Thanks, I missed that.

Reviewed-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>

> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  drivers/regulator/qcom_smd-regulator.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c
> index 9d093ae..9c6167d 100644
> --- a/drivers/regulator/qcom_smd-regulator.c
> +++ b/drivers/regulator/qcom_smd-regulator.c
> @@ -203,6 +203,7 @@ static const struct regulator_desc pm8941_nldo = {
>  
>  static const struct regulator_desc pm8941_lnldo = {
>  	.fixed_uV = 1740000,
> +	.n_voltages = 1,
>  	.ops = &rpm_smps_ldo_ops,
>  };
>  
> -- 
> 2.1.0
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] regulator: qcom_smd: Set n_voltages for pm8941_lnldo Axel Lin <axel.lin@ingics.com> - 2015-08-19 05:20 +0200
  Re: [PATCH] regulator: qcom_smd: Set n_voltages for pm8941_lnldo Bjorn Andersson <bjorn.andersson@sonymobile.com> - 2015-08-19 18:10 +0200

csiph-web