Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1209881

Re: [PATCH v4 0/2] kconfig: warn of unhandled characters in Kconfig commands

Show all headers | View raw

On 2015-07-20 10:54, Ulf Magnusson wrote:
> On Sun, Jul 12, 2015 at 09:41:49AM +0200, Andreas Ruprecht wrote:
>> This patchset changes the lexer file to emit a warning if any unhandled
>> characters are found in the input. So far, Kconfig options like
>>
>>  +config FOO
>>     bool
>>     [...]
>>
>> (note the wrong '+'!) were parsed without a warning. As simply adding a
>> warning for '.' produces lots of warnings as occasionally '---help---'
>> is used instead of 'help' (and thus '-' is recognized as an unhandled
>> character), we need to handle '---help---' separately.
>>
>> Changes to v1:
>> 	- add '---help---' in zconf.gperf instead of special casing
>> 	  it in zconf.l
>>
>> Changes to v2:
>> 	- Do no constify char parameter to warn_ignored_character
>> 	- Shorten rule definitions for '.'
>>
>> Changes to v3:
>> 	- spaces -> tabs in zconf.gperf
>>
>> Andreas Ruprecht (2):
>>   kconfig: warn of unhandled characters in Kconfig commands
>>   kconfig: Regenerate shipped zconf.{hash,lex}.c files
>>
>>  scripts/kconfig/zconf.gperf          |   1 +
>>  scripts/kconfig/zconf.hash.c_shipped |  58 ++++---
>>  scripts/kconfig/zconf.l              |  20 ++-
>>  scripts/kconfig/zconf.lex.c_shipped  | 325 +++++++++++++++++------------------
>>  4 files changed, 204 insertions(+), 200 deletions(-)
>>
>> -- 
>> 1.9.1
>>
> 
> For what it's worth:
> 
> Reviewed-by: Ulf Magnusson <ulfalizer@gmail.com>
> Tested-by: Ulf Magnusson <ulfalizer@gmail.com>

Applied to kbuild.git#kconfig.

Michal

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v4 0/2] kconfig: warn of unhandled characters in Kconfig  commands Michal Marek <mmarek@suse.cz> - 2015-08-19 17:10 +0200

csiph-web