Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1209856

Re: [PATCHv7 2/5] Staging: most: mostcore/core.c. Fix "Using plain integer as NULL pointer" warnings

Show all headers | View raw

On Fri, 14 Aug 2015 12:18:01 +0200
Adrian Remonda <adrianremonda@gmail.com> wrote:

> This patch fixes the warning generated by sparse: "Using plain integer
> as NULL pointer" by replacing the pointer test against 0 with a logical test.
> 
> Signed-off-by: Adrian Remonda <adrianremonda@gmail.com>
Acked-by: Christian Gromm <christian.gromm@microchip.com>
> ---
>  drivers/staging/most/mostcore/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/most/mostcore/core.c b/drivers/staging/most/mostcore/core.c
> index fa9c19b65a5c..7bb16db42893 100644
> --- a/drivers/staging/most/mostcore/core.c
> +++ b/drivers/staging/most/mostcore/core.c
> @@ -982,7 +982,7 @@ static ssize_t store_add_link(struct most_aim_obj *aim_obj,
>  	if (ret)
>  		return ret;
>  
> -	if (mdev_devnod == 0 || *mdev_devnod == 0) {
> +	if (!mdev_devnod || *mdev_devnod == 0) {
>  		snprintf(devnod_buf, sizeof(devnod_buf), "%s-%s", mdev, mdev_ch);
>  		mdev_devnod = devnod_buf;
>  	}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCHv7 2/5] Staging: most: mostcore/core.c. Fix "Using plain integer as NULL pointer" warnings Adrian Remonda <adrianremonda@gmail.com> - 2015-08-14 12:20 +0200
  Re: [PATCHv7 2/5] Staging: most: mostcore/core.c. Fix "Using plain  integer as NULL pointer" warnings Christian Gromm <christian.gromm@microchip.com> - 2015-08-19 16:40 +0200

csiph-web