Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1211241

RE: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for suspend

Show all headers | View raw

Hi, Nigel

> -----Original Message-----
> From: Nigel Cunningham [mailto:nigel@nigelcunningham.com.au]
> Sent: Friday, August 21, 2015 8:35 PM
> To: Chen, Yu C; rjw@rjwysocki.net; pavel@ucw.cz; tglx@linutronix.de;
> mingo@redhat.com; hpa@zytor.com
> Cc: Zhang, Rui; lenb@kernel.org; x86@kernel.org; linux-pm@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for
> suspend
> 
> Hi Chen.
> 
> Is there any issue with saving and restoring MSRs unconditionally? That
> would simplify the patch and make things 'just work'.
Saving/restoring unconditionally might take BIOS legal action into account,
for example, BIOS itself is willing to modify the MSR.  And Pavel suggests
using quirk to workaround in V1 patch:
https://patchwork.kernel.org/patch/7023891/

So I'm considering a common framework to save/restore these MSRs,
because user might need to protect more than one MSR during 
suspend, so..

I can modify this patch to a simpler version, for example,
Introducing two variables in struct saved_context , like
MSR_IA32_MISC_ENABLE does.

Thanks for your review

Best Regards,
Yu
> 
> Regards,
> 
> Nigel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] [v2] x86, suspend: Save/restore extra MSR registers for suspend Chen Yu <yu.c.chen@intel.com> - 2015-08-21 14:00 +0200
  Re: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for  suspend Nigel Cunningham <nigel@nigelcunningham.com.au> - 2015-08-21 14:40 +0200
    RE: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for  suspend "Chen, Yu C" <yu.c.chen@intel.com> - 2015-08-21 18:30 +0200
  Re: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for  suspend Pavel Machek <pavel@ucw.cz> - 2015-08-22 22:40 +0200
    Re: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for  suspend Ingo Molnar <mingo@kernel.org> - 2015-08-23 08:30 +0200
      Re: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for  suspend Pavel Machek <pavel@ucw.cz> - 2015-08-23 10:50 +0200
        RE: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for  suspend "Chen, Yu C" <yu.c.chen@intel.com> - 2015-08-24 05:30 +0200
      RE: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for  suspend "Chen, Yu C" <yu.c.chen@intel.com> - 2015-08-24 05:30 +0200
  Re: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for  suspend Borislav Petkov <bp@alien8.de> - 2015-08-24 10:50 +0200
    RE: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for  suspend "Chen, Yu C" <yu.c.chen@intel.com> - 2015-08-25 04:00 +0200

csiph-web