Re: [PATCH] usb: hub: remove redundant declarations

From	Felipe Balbi <balbi@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] usb: hub: remove redundant declarations
Date	2015-08-21 16:40 +0200
Message-ID	<pZVE5-6qd-5@gated-at.bofh.it> (permalink)
References	<pZVE5-6qd-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Aug 21, 2015 at 10:26:00AM -0400, Kris Borer wrote:
> Fix two occurrences of the Sparse warning:
> 
> warning: symbol XXX shadows an earlier one
> 
> Signed-off-by: Kris Borer <kborer@gmail.com>

Reviewed-by: Felipe Balbi <balbi@ti.com>

> ---
>  drivers/usb/core/hub.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index 431839b..a0db6a4 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -1070,7 +1070,7 @@ static void hub_activate(struct usb_hub *hub, enum hub_activation_type type)
>  		 * for HUB_POST_RESET, but it's easier not to.
>  		 */
>  		if (type == HUB_INIT) {
> -			unsigned delay = hub_power_on_good_delay(hub);
> +			delay = hub_power_on_good_delay(hub);
>  
>  			hub_power_on(hub, false);
>  			INIT_DELAYED_WORK(&hub->init_work, hub_init_func2);
> @@ -1404,7 +1404,6 @@ static int hub_configure(struct usb_hub *hub,
>  	/* FIXME for USB 3.0, skip for now */
>  	if ((wHubCharacteristics & HUB_CHAR_COMPOUND) &&
>  			!(hub_is_superspeed(hdev))) {
> -		int	i;
>  		char	portstr[USB_MAXCHILDREN + 1];
>  
>  		for (i = 0; i < maxchild; i++)
> -- 
> 1.9.1
> 

-- 
balbi

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] usb: hub: remove redundant declarations Felipe Balbi <balbi@ti.com> - 2015-08-21 16:40 +0200

csiph-web