Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1211151

RE: [PATCH 9/9] f2fs: update extent tree in batches

Show all headers | View raw

Hi Jaegeuk,

> -----Original Message-----
> From: Jaegeuk Kim [mailto:jaegeuk@kernel.org]
> Sent: Friday, August 21, 2015 1:48 AM
> To: Chao Yu
> Cc: linux-f2fs-devel@lists.sourceforge.net; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 9/9] f2fs: update extent tree in batches
> 
> Hi Chao,
> 
> On Wed, Aug 19, 2015 at 07:21:48PM +0800, Chao Yu wrote:
> > This patch introduce a new helper f2fs_update_extent_tree_range
> > which can update extent nodes in extent tree in batches.
> >
> > Now, we use the function to invalidate blocks in batches instead of
> > invalidating them one by one when truncating blocks.
> 
> IMO, it's not clear the benefit of this patch in terms of performance and code
> readability versus risky code changes.

This is only used in truncate path, IMO, in theory, we can gain benefit from
this batch mode operation when truncating frequently.

I will test the patch for numbers.

Thanks,

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 9/9] f2fs: update extent tree in batches Jaegeuk Kim <jaegeuk@kernel.org> - 2015-08-20 19:50 +0200
  RE: [PATCH 9/9] f2fs: update extent tree in batches Chao Yu <chao2.yu@samsung.com> - 2015-08-21 15:00 +0200
    RE: [f2fs-dev] [PATCH 9/9] f2fs: update extent tree in batches Chao Yu <chao2.yu@samsung.com> - 2015-08-25 11:40 +0200
      RE: [f2fs-dev] [PATCH 9/9] f2fs: update extent tree in batches Chao Yu <chao2.yu@samsung.com> - 2015-08-25 11:50 +0200
        Re: [f2fs-dev] [PATCH 9/9] f2fs: update extent tree in batches Jaegeuk Kim <jaegeuk@kernel.org> - 2015-08-26 00:30 +0200
          RE: [f2fs-dev] [PATCH 9/9] f2fs: update extent tree in batches Chao Yu <chao2.yu@samsung.com> - 2015-08-26 14:40 +0200

csiph-web