Re: [PATCH V4 1/7] perf,tools: introduce generic FEAT for CPU attributes

From	Jiri Olsa <jolsa@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V4 1/7] perf,tools: introduce generic FEAT for CPU attributes
Date	2015-08-21 11:00 +0200
Message-ID	<pZQl4-77f-3@gated-at.bofh.it> (permalink)
References	<pYWLU-27E-5@gated-at.bofh.it> <pYWLU-27E-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Aug 18, 2015 at 10:16:35AM -0400, Kan Liang wrote:

SNIP

> diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
> index 179b2bd..0a06fb8 100644
> --- a/tools/perf/util/header.c
> +++ b/tools/perf/util/header.c
> @@ -862,6 +862,23 @@ write_it:
>  	return do_write_string(fd, buffer);
>  }
>  
> +#define MAX_FREQ_TAG_STR	"max_freq"
> +
> +static int write_cpu_attributes(int fd, struct perf_header *h __maybe_unused,
> +				struct perf_evlist *evlist __maybe_unused)
> +{
> +	u64 freq;
> +	int ret;
> +
> +	freq = get_cpu_max_freq();
> +
> +	ret = do_write_string(fd, MAX_FREQ_TAG_STR);
> +	if (ret)
> +		return ret;

why not store just the tag number? PERF_HEADER_CPU_MAX_FREQ

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH V4 1/7] perf,tools: introduce generic FEAT for CPU  attributes Jiri Olsa <jolsa@redhat.com> - 2015-08-21 11:00 +0200

csiph-web