Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1210987

Re: [PATCH 1/4] [media] staging: omap4iss: get entity ID using media_entity_id()

Show all headers | View raw

On 08/21/2015 02:15 AM, Laurent Pinchart wrote:
> Hi Javier,
> 
> On Friday 21 August 2015 02:14:05 Javier Martinez Canillas wrote:
>> On 08/20/2015 08:37 PM, Laurent Pinchart wrote:
>>> On Wednesday 19 August 2015 17:35:19 Javier Martinez Canillas wrote:
>>>> The struct media_entity does not have an .id field anymore since
>>>> now the entity ID is stored in the embedded struct media_gobj.
>>>>
>>>> This caused the omap4iss driver fail to build. Fix by using the
>>>> media_entity_id() macro to obtain the entity ID.
>>>>
>>>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>>
>>> This looks fine to me. The patch needs to be moved between Mauro's 1/8 and
>>> 2/8 patches to avoid breaking bisection with patch 3/8. I'd squash this
>>> patch and 2/4 into a single "media: Use media_entity_id() in drivers"
>>> patch.
>>
>> Yes, Hans and Mauro already mentioned it and I completely agree that
>> should be squashed with Mauro's patch to maintain git bisect-ability.
> 
> I wouldn't squash patches 1/4 and 2/4 into Mauro's 3/8 patch as Hans proposed, 
> but instead squashing them together into a single patch and move the result as 
> 1.5/8 in Mauro's series.
> 

I agree with Laurent, this is a better solution.

Regards,

	Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/4] [media] staging: omap4iss: get entity ID using media_entity_id() Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2015-08-20 20:40 +0200
  Re: [PATCH 1/4] [media] staging: omap4iss: get entity ID using media_entity_id() Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2015-08-21 02:20 +0200
    Re: [PATCH 1/4] [media] staging: omap4iss: get entity ID using  media_entity_id() Javier Martinez Canillas <javier@osg.samsung.com> - 2015-08-21 02:40 +0200
    Re: [PATCH 1/4] [media] staging: omap4iss: get entity ID using media_entity_id() Hans Verkuil <hverkuil@xs4all.nl> - 2015-08-21 10:00 +0200
  Re: [PATCH 1/4] [media] staging: omap4iss: get entity ID using  media_entity_id() Javier Martinez Canillas <javier@osg.samsung.com> - 2015-08-21 02:20 +0200

csiph-web