Re: CONFIG_OF vs DMA_OF

From	Vinod Koul <vinod.koul@intel.com>
Newsgroups	linux.kernel
Subject	Re: CONFIG_OF vs DMA_OF
Date	2015-08-21 10:30 +0200
Message-ID	<pZPS1-6zf-11@gated-at.bofh.it> (permalink)
References	<pZNdv-2Jq-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Aug 21, 2015 at 05:35:58AM +0000, Kuninori Morimoto wrote:
> 
> Hi Vinod
> 
> ${LINUX}/drivers/dma/of-dma.c will be compiled if .config has DMA_OF
> 
> 	obj-$(CONFIG_DMA_OF) += of-dma.o
> 
> But, ${LINUX}/include/linux/of_dma.h is based on CONFIG_OF

Intially it was OF only and then DMA_OF was added. I think we missed it
during the move, so yes your below patch makes sense

Can you please send as formal patch for me to apply

-- 
~Vinod

> 
> 	#ifdef CONFIG_OF
> 	extern int of_dma_controller_register(struct device_node *np,
> 	...
> 	#else
> 	static inline int of_dma_controller_register(struct device_node *np,
> 	...
> 	#endif
> 
> I have issue if .config has CONFIG_OF but not have DMA_OF.
> Is this correct patch ?
> 
> ---------------------------------
> diff --git a/include/linux/of_dma.h b/include/linux/of_dma.h
> index 98ba752..9440622 100644
> --- a/include/linux/of_dma.h
> +++ b/include/linux/of_dma.h
> @@ -34,7 +34,7 @@ struct of_dma_filter_info {
>         dma_filter_fn   filter_fn;
>  };
>  
> -#ifdef CONFIG_OF
> +#ifdef DMA_OF
>  extern int of_dma_controller_register(struct device_node *np,
>                 struct dma_chan *(*of_dma_xlate)
>                 (struct of_phandle_args *, struct of_dma *),
> ---------------------------------
> 
> 
> Best regards
> ---
> Kuninori Morimoto

-- 
-- 
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

CONFIG_OF vs DMA_OF Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> - 2015-08-21 07:40 +0200
  Re: CONFIG_OF vs DMA_OF Vinod Koul <vinod.koul@intel.com> - 2015-08-21 10:30 +0200
    Re: [PATCH 1/2] dmaengine: OF DMAEngine API based on CONFIG_DMA_OF  instead of CONFIG_OF Vinod Koul <vinod.koul@intel.com> - 2015-08-24 11:20 +0200

csiph-web