Re: [PATCH] rtc: s5m: fix to update ctrl register

From	Krzysztof Kozlowski <k.kozlowski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] rtc: s5m: fix to update ctrl register
Date	2015-08-21 02:50 +0200
Message-ID	<pZIGS-4zi-9@gated-at.bofh.it> (permalink)
References	<pWWn1-6Ab-13@gated-at.bofh.it> <pZHhM-2HW-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 21.08.2015 08:15, Alexandre Belloni wrote:
> Hi,
> 
> On 13/08/2015 at 17:49:24 +0900, Joonyoung Shim wrote :
>> According to datasheet, the S2MPS13X and S2MPS14X should update write
>> buffer via setting WUDR bit to high after ctrl register is updated.
>>
>> If not, ALARM interrupt of rtc-s5m doesn't happen first time when i use
>> tools/testing/selftests/timers/rtctest.c test program and hour format is
>> used to 12 hour mode in Odroid-XU3 board.
>>
> 
>>From what I understood, I should expect a v2 of tihat patch also setting
> RUDR, is that right? OR would you prefer that I apply that one and then
> fix RUDR in a following patch?

Right, I would expect that as well... or a comment if this is not needed.

Best regards,
Krzysztof


> 
>> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
>> Cc: <stable@vger.kernel.org>
> 
> can you update the stable tag with the kernel version introducing the
> issue?
> 
>> ---
>>  drivers/rtc/rtc-s5m.c | 12 ++++++++++++
>>  1 file changed, 12 insertions(+)
> 
>> diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c
>> index 8c70d78..03828bb 100644
>> --- a/drivers/rtc/rtc-s5m.c
>> +++ b/drivers/rtc/rtc-s5m.c
>> @@ -635,6 +635,18 @@ static int s5m8767_rtc_init_reg(struct s5m_rtc_info *info)
>>  	case S2MPS13X:
>>  		data[0] = (0 << BCD_EN_SHIFT) | (1 << MODEL24_SHIFT);
>>  		ret = regmap_write(info->regmap, info->regs->ctrl, data[0]);
>> +		if (ret < 0)
>> +			break;
>> +
>> +		ret = regmap_update_bits(info->regmap,
>> +				info->regs->rtc_udr_update,
>> +				info->regs->rtc_udr_mask,
>> +				info->regs->rtc_udr_mask);
> 
> Very small indentation issue here, it should be aligned with the open
> parenthesis.
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH] rtc: s5m: fix to update ctrl register Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-08-21 01:20 +0200
  Re: [PATCH] rtc: s5m: fix to update ctrl register Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-08-21 02:50 +0200
    Re: [PATCH] rtc: s5m: fix to update ctrl register Joonyoung Shim <jy0922.shim@samsung.com> - 2015-08-21 03:10 +0200
      Re: [PATCH] rtc: s5m: fix to update ctrl register Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-08-21 03:30 +0200
        Re: [PATCH] rtc: s5m: fix to update ctrl register Joonyoung Shim <jy0922.shim@samsung.com> - 2015-08-21 09:00 +0200
          Re: [PATCH] rtc: s5m: fix to update ctrl register Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-08-21 09:30 +0200
            Re: [PATCH] rtc: s5m: fix to update ctrl register Joonyoung Shim <jy0922.shim@samsung.com> - 2015-08-21 11:00 +0200
              Re: [PATCH] rtc: s5m: fix to update ctrl register Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-08-21 11:30 +0200

csiph-web