Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1210787

Re: [PATCHv3 3/5] mm: pack compound_dtor and compound_order into one word in struct page

Show all headers | View raw

On Wed, 19 Aug 2015 12:21:44 +0300 "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> wrote:

> The patch halves space occupied by compound_dtor and compound_order in
> struct page.
> 
> For compound_order, it's trivial long -> int/short conversion.
> 
> For get_compound_page_dtor(), we now use hardcoded table for destructor
> lookup and store its index in the struct page instead of direct pointer
> to destructor. It shouldn't be a big trouble to maintain the table: we
> have only two destructor and NULL currently.
> 
> This patch free up one word in tail pages for reuse. This is preparation
> for the next patch.
> 
> ...
>
> @@ -145,8 +143,13 @@ struct page {
>  						 */
>  		/* First tail page of compound page */
>  		struct {
> -			compound_page_dtor *compound_dtor;
> -			unsigned long compound_order;
> +#ifdef CONFIG_64BIT
> +			unsigned int compound_dtor;
> +			unsigned int compound_order;
> +#else
> +			unsigned short int compound_dtor;
> +			unsigned short int compound_order;
> +#endif

Why not use ushort for 64-bit as well?

It would be clearer if that new enum had a name, so we use "enum
compound_dtor_id" everywhere instead of a bare uint.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCHv3 3/5] mm: pack compound_dtor and compound_order into  one word in struct page Andrew Morton <akpm@linux-foundation.org> - 2015-08-21 01:30 +0200
  Re: [PATCHv3 3/5] mm: pack compound_dtor and compound_order into one  word in struct page Michal Hocko <mhocko@kernel.org> - 2015-08-21 09:20 +0200
    Re: [PATCHv3 3/5] mm: pack compound_dtor and compound_order into one  word in struct page "Kirill A. Shutemov" <kirill@shutemov.name> - 2015-08-21 12:50 +0200
      Re: [PATCHv3 3/5] mm: pack compound_dtor and compound_order into one  word in struct page Michal Hocko <mhocko@kernel.org> - 2015-08-21 13:00 +0200

csiph-web