Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1210795

Re: [PATCH v2 6/8] scsi: ufs: make the UFS variant a platform device

Show all headers | View raw

2015-08-20 22:59 GMT+09:00 Yaniv Gardi <ygardi@codeaurora.org>:
> @@ -1036,7 +1037,7 @@ void ufs_qcom_clk_scale_notify(struct ufs_hba *hba)
>   * The variant operations configure the necessary controller and PHY
>   * handshake during initialization.
>   */
> -static const struct ufs_hba_variant_ops ufs_hba_qcom_vops = {
> +static struct ufs_hba_variant_ops ufs_hba_qcom_vops = {

It's better to keep const.  In order to do this, we also need to put
const to 'vops' member in struct ufs_hba and the second argument of
ufshcd_pltfrm_init().

> +static void ufs_qcom_shutdown(struct platform_device *pdev)
> +{
> +       ufshcd_shutdown((struct ufs_hba *)platform_get_drvdata(pdev));
> +}

We don't need this function anymore since we have
ufshcd_pltfrm_shutdown() now.

> -static void ufshcd_pltfrm_shutdown(struct platform_device *pdev)
> +void ufshcd_pltfrm_shutdown(struct platform_device *pdev)
>  {
> -       ufshcd_shutdown((struct ufs_hba *)platform_get_drvdata(pdev));
> +       ufshcd_shutdown((struct ufs_hba *)platform_get_drvdata(pdev));

Whitespace is used as code indent.  There are same issues in
this patch series, so I recommend running checkpatch.pl before
sending patches.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 6/8] scsi: ufs: make the UFS variant a platform device Yaniv Gardi <ygardi@codeaurora.org> - 2015-08-20 16:00 +0200
  Re: [PATCH v2 6/8] scsi: ufs: make the UFS variant a platform device Akinobu Mita <akinobu.mita@gmail.com> - 2015-08-21 01:50 +0200
    Re: [PATCH v2 6/8] scsi: ufs: make the UFS variant a platform  device ygardi@codeaurora.org - 2015-08-22 00:30 +0200
  Re: [PATCH v2 6/8] scsi: ufs: make the UFS variant a platform device Rob Herring <robherring2@gmail.com> - 2015-08-23 23:10 +0200
    Re: [PATCH v2 6/8] scsi: ufs: make the UFS variant a platform  device ygardi@codeaurora.org - 2015-08-24 10:40 +0200

csiph-web